Fix NVDA not reading the ribbon in Geekbench 6.4#17937
Merged
Merged
Conversation
See test results for failed build of commit e0d79c3af8 |
seanbudd
reviewed
Apr 10, 2025
seanbudd
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17892
Summary of the issue:
NVDA Does not read the controls in the Geekbench 6.4 ribbon when navigating and errors in the log.
Description of user facing changes
The menu can be navigated and interacted with normally.
Description of development approach
Geekbench uses something similar to the Microsoft Office ribbon. The code to check for older Office versions expected a normal productVersion for Office apps, however, Geekbench's productVersion is "6,4,0,0". This is the cause of the ValueError. I've fixed this by only checking the version if isOfficeApp is True first.
Testing strategy:
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary