Skip to content

Fix NVDA not reading the ribbon in Geekbench 6.4#17937

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
mzanm:geekbench6fix
Apr 10, 2025
Merged

Fix NVDA not reading the ribbon in Geekbench 6.4#17937
seanbudd merged 3 commits into
nvaccess:masterfrom
mzanm:geekbench6fix

Conversation

@mzanm

@mzanm mzanm commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #17892

Summary of the issue:

NVDA Does not read the controls in the Geekbench 6.4 ribbon when navigating and errors in the log.

Description of user facing changes

The menu can be navigated and interacted with normally.

Description of development approach

Geekbench uses something similar to the Microsoft Office ribbon. The code to check for older Office versions expected a normal productVersion for Office apps, however, Geekbench's productVersion is "6,4,0,0". This is the cause of the ValueError. I've fixed this by only checking the version if isOfficeApp is True first.

Testing strategy:

  • Tested that the Geekbench ribbon can be navigated and interacted with.
  • Tested the Microsoft Office ribbon just in case.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@mzanm mzanm marked this pull request as ready for review April 10, 2025 17:50
@mzanm mzanm requested a review from a team as a code owner April 10, 2025 17:50
@mzanm mzanm requested a review from seanbudd April 10, 2025 17:50
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit e0d79c3af8

Comment thread user_docs/en/changes.md Outdated

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mzanm, nice catch

@seanbudd seanbudd merged commit d0615f0 into nvaccess:master Apr 10, 2025
@github-actions github-actions Bot added this to the 2025.2 milestone Apr 10, 2025
@mzanm mzanm deleted the geekbench6fix branch April 11, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA does not read in Geekbench 6.4

3 participants