Link to issue number:

Addresses #17670 for the classic Windows Calculator. Follow-up to PR #17905.

Summary of the issue:

Similar to the issue observed in the modern Windows Calculator, the classic Windows Calculator's display area does not consistently trigger character echo when NVDA's "Speak typed characters" setting is configured to 'Only in edit controls'.

Description of user facing changes

Users will now hear typed characters echoed when typing into the display field of the classic Windows Calculator, even when the "Speak typed characters" option is set to 'Only in edit controls'.

Description of development approach

This change mirrors the approach taken for the modern Calculator in PR #17905.
The event_typedCharacter method within the Display overlay class (which specifically targets the display controls of the classic Calculator in calc.py) is modified. When this event occurs and the original speakTypedCharacters mode is EDIT_CONTROLS, the mode is temporarily switched to ALWAYS before calling the parent class's event handler. The original mode is then restored in a finally block.

Testing strategy:

Manual testing with the classic Windows Calculator (Windows 10 LTSC, calc.exe):

1. Set NVDA's "Speak typed characters" setting (Keyboard Settings) to 'Only in edit controls'.
2. Open the classic Calculator (calc.exe).
3. Type numbers and operators (e.g., 1, +, 2, *, 3, =).
4. Confirm each typed character is spoken.
5. Change the setting to 'Always' and confirm characters are spoken.
6. Change the setting to 'Off' and confirm characters are not spoken.

Known issues with pull request:

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

@coderabbitai summary