Images with role=math but no actual mathml should be treated as normal images#17832
Merged
Conversation
See test results for failed build of commit c9f42c9068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #16007
Summary of the issue:
In the past, many content publishers have been representing math equations is an image along with alt text containing some kind of plain-text math representation, rather than using actual mathml. However, they have also been placing role=math on these images, which confuses NVDA. The image then no longer is treated in browse mode like an image (it does not report graphic, you can't jump to it with g, nor can you arrow through the alt text character by character). And since there is no mathml for rich navigation, the equation cannot be navigated through at all.
Description of user facing changes
gand to be able to arrow through the alt text by character. (NVDA not properly present an image when role="math" is present #16007)Description of development approach
tagIAccessible2 object attribute isimg, as this Accessible represents an image, whose role has been inappropriately overridden to equation by an ARIA role ofmath. This then allows all standard logic for images to apply in Browse Moe for this node.Testing strategy:
Known issues with pull request:
None known.
Code Review Checklist:
@coderabbitai summary