Conversation
8 tasks
LeonarddeR
reviewed
Mar 11, 2025
seanbudd
approved these changes
Mar 26, 2025
Merged
SaschaCowley
pushed a commit
that referenced
this pull request
Mar 26, 2025
Raised in #17809 (comment) Summary of the issue: There is variable name shadowing for `dict` in our `AutoPropertyType` initializers. `ABCMeta` uses the term `namespace` instead of `dict` to avoid this conflict. Description of user facing changes None Description of development approach replace variable usages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up to 17744
Summary of the issue:
As pointed out in #17744 (comment), the type hint for the
dictargument tobaseObject.ScriptableType.__new__is incorrectly[str, Any]since #17744 was merged.Description of user facing changes
None.
Description of development approach
Corrected the type annotation to
dict[str, Any].Testing strategy:
Automated tests via CI.
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary