Fix update check when no update is available#17804
Merged
Merged
Conversation
See test results for failed build of commit 37c53ddade |
Collaborator
|
@christopherpross I'm afraid you commited something wrong here. There's only a versionInfo.py change that adds a random alpha version. Please double check whether this is correct. |
f542fa1 to
c89f9a5
Compare
Contributor
Author
|
@LeonarddeR sorry, something is wrong with my git tool here. I commit now the right file. |
Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>
SaschaCowley
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17800
Follow-up of #17310
Summary of the issue:
The changes introduced in PR #17310 had a bug. If the version being checked for an update is the latest for the given versionType, the server returns an empty response. This caused an error because the required keys for a valid update response were missing.
Description of user facing changes
With the update mirror validation in place, checking for updates while running the latest version will now correctly result in the standard message indicating that no update is available.
Description of development approach
Testing strategy:
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary