Fix-up #17720 for sheets containing comma#17754
Merged
Merged
Conversation
5 tasks
Contributor
Author
|
Cc @michaelDCurran if you also wish to review this. |
michaelDCurran
approved these changes
Mar 2, 2025
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
This looks okay. Noting though that if this function were called with a relative address (no file/sheet) then it would return the address as the file/sheet and an empty address. We are not calling it like this so it is okay. But just pointing that out.
seanbudd
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of #17720
Summary of the issue:
#17720 fixed Excel element list dialog on non-English system, using the local list separator to request a range. Though, the way it was implemented could fail in case the Excel file or sheet names also contained a comma.
Description of user facing changes
Listing comments or formulas in Excel no longer fails when the name of the file or the sheet contains a comma.
Description of development approach
Testing strategy:
Tested with names containing special characters used in range definition, i.e. with a file named "Test,$!foo!$,bar.xlsx" and in a sheet named "Sheet.- ,;$!foo".
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary