Skip to content

Add an unassigned command to toggle periodical refresh of the Windows OCR result#17740

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
CyrilleB79:toggleAutoRecog
Feb 25, 2025
Merged

Add an unassigned command to toggle periodical refresh of the Windows OCR result#17740
seanbudd merged 2 commits into
nvaccess:masterfrom
CyrilleB79:toggleAutoRecog

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Discussed in #15331 (review) and following

Summary of the issue:

Most options in the UI have an associated toggle script (assigned or unassigned). In Windows OCR settings, "Periodically refresh recognized content" has no such toggle script.

Description of user facing changes

An unassigned command has been added to toggle the value of "Periodically refresh recognized content". In an OCR result, using this script takes immediately effect.

Description of development approach

  • Use the toggle helper fonction defined for global commands.
  • If the final state is enabled, schedule a new recognition
  • If the final state is disabled, nothing more needs to be done, the next recognition will not schedule subsequent ones.

Testing strategy:

Manual testing in the OCR result and out of it.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@CyrilleB79 CyrilleB79 marked this pull request as ready for review February 25, 2025 17:37
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner February 25, 2025 17:37
@CyrilleB79 CyrilleB79 requested a review from seanbudd February 25, 2025 17:37

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit 5bfc408 into nvaccess:master Feb 25, 2025
@github-actions github-actions Bot added this to the 2025.1 milestone Feb 25, 2025
@CyrilleB79 CyrilleB79 deleted the toggleAutoRecog branch February 26, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants