Skip to content

Excel: for selection covering more than one cell, announce the active cell when pressing Enter or Tab rather than the whole selection range#17733

Merged
seanbudd merged 13 commits intonvaccess:masterfrom
CyrilleB79:announceExcelActiveCell2
Jul 14, 2025
Merged

Conversation

@CyrilleB79
Copy link
Copy Markdown
Contributor

@CyrilleB79 CyrilleB79 commented Feb 24, 2025

Link to issue number:

Closes #6959

Summary of the issue:

When multiple cells are selected, pressing commands that move the active cell (even in a selection) do not allow to report which cell is active in the selection. We should more clearly distinguish between the selection and the active cell in Excel.

This had already been done for Libre Office in #12849.

Description of user facing changes

When multiple cells are selected in an Excel sheet, pressing enter, tab combined or not with shift to move the active cell now reports the new active cell rather than the whole selection.

If needed, the whole selection can still be reported with NVDA+shift+upArrow.

Description of development approach

  • Spit the original script in two separate script to handle selection and focus (active cell) reporting separately.
  • For charts, the selection is reported in any case as before, there is no concept of active cell

Testing strategy:

In a worksheet test for single selected cell and multiple cells selected:

  • pressing arrows
  • pressing enter, tab combined or not with shift
  • report focus: NVDA+tab
  • report navigator object: NVDA+pavnum5
  • report selection: NVDA+shift+upArrow

Also test these scripts in a chart.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

Cyrille Bougot and others added 2 commits February 25, 2025 00:01
…he active cell when pressing Enter or Tab rather than the whole selection range.
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Feb 24, 2025
@AppVeyorBot
Copy link
Copy Markdown

See test results for failed build of commit cfa6189136

@SaschaCowley
Copy link
Copy Markdown
Member

@CyrilleB79 what is the status of this PR?

@CyrilleB79
Copy link
Copy Markdown
Contributor Author

I have still to work on it. For now, I have caused a regression when the selection in graphics/charts needs to be reported.

@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Jun 2, 2025

Hi @CyrilleB79 - do you need any support with handling the regression? Do you still plan on working on this?

@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 3, 2025 14:12
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 3, 2025 14:12
@CyrilleB79 CyrilleB79 requested a review from seanbudd June 3, 2025 14:12
@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Jun 4, 2025

Can you please fill out the PR template as well

@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Jun 4, 2025

and also fix up the pre-commit failure

@CyrilleB79 CyrilleB79 marked this pull request as draft June 4, 2025 14:10
@seanbudd seanbudd marked this pull request as ready for review July 14, 2025 01:01
@seanbudd seanbudd merged commit a0bf15c into nvaccess:master Jul 14, 2025
2 of 5 checks passed
@SaschaCowley SaschaCowley added this to the 2025.3 milestone Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excel: Current cell incorrectly announced when multiple cells selected

4 participants