Excel: for selection covering more than one cell, announce the active cell when pressing Enter or Tab rather than the whole selection range#17733
Merged
seanbudd merged 13 commits intonvaccess:masterfrom Jul 14, 2025
Conversation
…he active cell when pressing Enter or Tab rather than the whole selection range.
See test results for failed build of commit cfa6189136 |
Member
|
@CyrilleB79 what is the status of this PR? |
Contributor
Author
|
I have still to work on it. For now, I have caused a regression when the selection in graphics/charts needs to be reported. |
Member
|
Hi @CyrilleB79 - do you need any support with handling the regression? Do you still plan on working on this? |
seanbudd
approved these changes
Jun 4, 2025
Member
|
Can you please fill out the PR template as well |
Member
|
and also fix up the pre-commit failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #6959
Summary of the issue:
When multiple cells are selected, pressing commands that move the active cell (even in a selection) do not allow to report which cell is active in the selection. We should more clearly distinguish between the selection and the active cell in Excel.
This had already been done for Libre Office in #12849.
Description of user facing changes
When multiple cells are selected in an Excel sheet, pressing
enter,tabcombined or not withshiftto move the active cell now reports the new active cell rather than the whole selection.If needed, the whole selection can still be reported with
NVDA+shift+upArrow.Description of development approach
Testing strategy:
In a worksheet test for single selected cell and multiple cells selected:
enter,tabcombined or not withshiftNVDA+tabNVDA+pavnum5NVDA+shift+upArrowAlso test these scripts in a chart.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary