Skip to content

Update eSpeak to 1.52.0 stable#17583

Merged
seanbudd merged 3 commits into
masterfrom
espeak20252
Jan 13, 2025
Merged

Update eSpeak to 1.52.0 stable#17583
seanbudd merged 3 commits into
masterfrom
espeak20252

Conversation

@seanbudd

@seanbudd seanbudd commented Jan 6, 2025

Copy link
Copy Markdown
Member

Link to issue number:

Closes #17056

Summary of the issue:

Janitorial update of eSpeak

Description of user facing changes

None

Description of development approach

Followed instructions in espeak.md, no changes to eSpeak required.

Testing strategy:

Ran eSpeak after compiling with 1.52.0 code

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd requested a review from a team as a code owner January 6, 2025 05:39
@seanbudd seanbudd requested a review from SaschaCowley January 6, 2025 05:39
@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jan 6, 2025
Comment thread user_docs/en/changes.md Outdated

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you may have forgotten to commit the newly checked out eSpeak.

@seanbudd seanbudd requested a review from SaschaCowley January 10, 2025 05:00
@seanbudd

Copy link
Copy Markdown
Member Author

@SaschaCowley d'oh!

Co-authored-by: Sean Budd <sean@nvaccess.org>

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @seanbudd

@seanbudd seanbudd merged commit f3163b9 into master Jan 13, 2025
@seanbudd seanbudd deleted the espeak20252 branch January 13, 2025 01:55
@github-actions github-actions Bot added this to the 2025.1 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update eSpeak-NG for 2025.1

2 participants