Skip to content

Update nuitka to 2.5.4#17464

Merged
SaschaCowley merged 3 commits into
nvaccess:masterfrom
josephsl:nuitka-2.5.4
Dec 1, 2024
Merged

Update nuitka to 2.5.4#17464
SaschaCowley merged 3 commits into
nvaccess:masterfrom
josephsl:nuitka-2.5.4

Conversation

@josephsl

@josephsl josephsl commented Dec 1, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #17458

Summary of the issue:

NVDA is using nuitka 2.4.8 (includes xliff for markdown to HTML generation).

Description of user facing changes

None

Description of development approach

Update nuitka to 2.5.4 and xliff is still working.

Testing strategy:

Manual and documentation generation: make sure nuitka/xliff is working after dependency upgrades.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@josephsl josephsl requested a review from a team as a code owner December 1, 2024 12:55
@josephsl josephsl requested a review from SaschaCowley December 1, 2024 12:55

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @josephsl

# Conflicts:
#	user_docs/en/changes.md
@SaschaCowley SaschaCowley merged commit 4a0bf1b into nvaccess:master Dec 1, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Dec 2, 2024
@josephsl josephsl deleted the nuitka-2.5.4 branch December 2, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update nuitka to 2.5.4

2 participants