Skip to content

Update requests to 2.32.3#17463

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
josephsl:requests-2.32.3
Dec 1, 2024
Merged

Update requests to 2.32.3#17463
seanbudd merged 2 commits into
nvaccess:masterfrom
josephsl:requests-2.32.3

Conversation

@josephsl

@josephsl josephsl commented Dec 1, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #17456

Summary of the issue:

NVDA is using requests 2.32.0.

Description of user facing changes

None

Description of development approach

Update requests to 2.32.3.

Testing strategy:

Manual and unit tests: make sure requests functions work after upgrading requests.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@josephsl josephsl requested a review from a team as a code owner December 1, 2024 12:54
@josephsl josephsl requested a review from seanbudd December 1, 2024 12:54
@seanbudd seanbudd merged commit 935e802 into nvaccess:master Dec 1, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Dec 1, 2024
@josephsl josephsl deleted the requests-2.32.3 branch December 2, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update requests to 2.32.3

2 participants