Skip to content

Update schedule to 1.2.2#17462

Merged
SaschaCowley merged 3 commits into
nvaccess:masterfrom
josephsl:schedule-1.2.2
Dec 1, 2024
Merged

Update schedule to 1.2.2#17462
SaschaCowley merged 3 commits into
nvaccess:masterfrom
josephsl:schedule-1.2.2

Conversation

@josephsl

@josephsl josephsl commented Dec 1, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #17455

Summary of the issue:

NVDA is using schedule 1.2.1.

Description of user facing changes

None

Description of development approach

Update schedule to 1.2.2 and perform compilation/testing.

Testing strategy:

Manual testing (with unit tests): make sure schedule functions are working after upgradin the dependency.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@josephsl josephsl requested a review from a team as a code owner December 1, 2024 12:48
@josephsl josephsl requested a review from SaschaCowley December 1, 2024 12:48
# Conflicts:
#	user_docs/en/changes.md

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @josephsl

@SaschaCowley SaschaCowley merged commit 728a896 into nvaccess:master Dec 1, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Dec 1, 2024
@josephsl josephsl deleted the schedule-1.2.2 branch December 2, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update schedule to 1.2.2

2 participants