Report the update of the selection when using Word selection extend / reduce commmands (f8 or shift+f8)#17424
Merged
Merged
Conversation
… reduce commmands (f8 or shift+f8)
Contributor
Author
|
@burmancomp I have received a message via e-mail regarding this PR, but it does not appears here, on the GitHub page of this PR. Have you removed it? If this PR is not working for you, could you provide a debug log? If it finally also works, just let me know. |
Contributor
|
Yes it works for me. My comment which I removed based on my missunderstanding of f8/shift+f8 functionality. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Partially fixes #3293.
Summary of the issue:
When using
f8(extend selection) orshift+f8(reduce selection) in Word, the selection changes are not reported.Description of user facing changes
When using
f8(extend selection) orshift+f8(reduce selection) in Word, the selection changes will now be reported.If the selection is extended / reduced at both ends, two consecutive selection update messages are reported, as done for
control+a(select all).Description of development approach
In
WordDocument.initOverlayClass, bindscript_caret_changeSelectiontof8andshift+f8, as already done for other gestures such asalt+shift+homeoralt+shift+pageDown.Testing strategy:
Manual test of
f8andshift+f8in Word and Outlook, with and without UIA.Test made on Windows 10, Word 2016 (Microsoft® Word 2016 MSO (Version 2410 Build 16.0.18129.20158) 32 bits).
Known issues with pull request:
This PR only reports selection change when
f8/shift+f8is pressed.Though this PR does not fix the following issues:
F8or when pressingescapeis not reported.Since these issues were pre-existing to this PR, my opinion is that this PR is already an improvement of the "extend selection mode" usage with respect to what was occurring before.
Code Review Checklist:
@coderabbitai summary