Skip to content

Update configobj#17371

Merged
SaschaCowley merged 1 commit into
masterfrom
i17328
Nov 8, 2024
Merged

Update configobj#17371
SaschaCowley merged 1 commit into
masterfrom
i17328

Conversation

@SaschaCowley

@SaschaCowley SaschaCowley commented Nov 7, 2024

Copy link
Copy Markdown
Member

Link to issue number:

Closes #17328

Summary of the issue:

Configobj has received a number of updates since we last updated, most significantly dropping Python 2 support and fixing security issues.

Description of user facing changes

None

Description of development approach

Updated configobj in requirements.txt.

Testing strategy:

Unit and system tests.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley requested a review from a team as a code owner November 7, 2024 03:34
@SaschaCowley SaschaCowley requested a review from seanbudd November 7, 2024 03:35
@SaschaCowley SaschaCowley linked an issue Nov 7, 2024 that may be closed by this pull request
Dependency: update configobj to 5.1.0 commit 8be54629 #17328
Closed
seanbudd
seanbudd reviewed Nov 7, 2024
View reviewed changes
Comment thread requirements.txt
@SaschaCowley

SaschaCowley commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

@seanbudd we're currently on 5.1, and it seems that downgrading to 5.0.9 breaks a bunch of unit tests.

Test output 
ERROR [0.000s]: test_argsMissingIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_argsMissingIsError)                                                                                                                       
----------------------------------------------------------------------                                                  
Traceback (most recent call last):                                                                                      
  File "D:\projects\nvda\tests\unit\test_config.py", line 112, in test_argsMissingIsError                               
    featureFlag._transformSpec_AddFeatureFlagDefault(                                                                   
  File "D:\projects\nvda\source\config\featureFlag.py", line 167, in _transformSpec_AddFeatureFlagDefault               
    raise VdtParamError(                                                                                                
          ^^^^^^^^^^^^^^                                                                                                
TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg'                                    
                                                                                                                        
======================================================================                                                  
ERROR [0.000s]: test_behaviorOfDefaultMissingIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_behaviorOfDefaultMissingIsError)                                                                                             
----------------------------------------------------------------------                                                  
Traceback (most recent call last):                                                                                      
  File "D:\projects\nvda\tests\unit\test_config.py", line 98, in test_behaviorOfDefaultMissingIsError                   
    featureFlag._transformSpec_AddFeatureFlagDefault(                                                                   
  File "D:\projects\nvda\source\config\featureFlag.py", line 192, in _transformSpec_AddFeatureFlagDefault               
    raise VdtParamError(                                                                                                
          ^^^^^^^^^^^^^^                                                                                                
TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg'                                    
                                                                                                                        
======================================================================                                                  
ERROR [0.000s]: test_behaviorOfDefaultTypeMustBeStr (tests.unit.test_config.Config_FeatureFlag_specTransform.test_behaviorOfDefaultTypeMustBeStr)                                                                                               
----------------------------------------------------------------------                                                  
Traceback (most recent call last):                                                                                      
  File "D:\projects\nvda\tests\unit\test_config.py", line 118, in test_behaviorOfDefaultTypeMustBeStr                   
    featureFlag._transformSpec_AddFeatureFlagDefault(                                                                   
  File "D:\projects\nvda\source\config\featureFlag.py", line 198, in _transformSpec_AddFeatureFlagDefault               
    raise VdtParamError(                                                                                                
          ^^^^^^^^^^^^^^                                                                                                
TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg'                                    
                                                                                                                        
======================================================================                                                  
ERROR [0.000s]: test_optionsEnumMissingIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_optionsEnumMissingIsError)                                                                                                         
----------------------------------------------------------------------                                                  
Traceback (most recent call last):                                                                                      
  File "D:\projects\nvda\tests\unit\test_config.py", line 105, in test_optionsEnumMissingIsError                        
    featureFlag._transformSpec_AddFeatureFlagDefault(                                                                   
  File "D:\projects\nvda\source\config\featureFlag.py", line 167, in _transformSpec_AddFeatureFlagDefault               
    raise VdtParamError(                                                                                                
          ^^^^^^^^^^^^^^                                                                                                
TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg'                                    
                                                                                                                        
======================================================================                                                  
ERROR [0.000s]: test_optionsEnumMustBeKnown (tests.unit.test_config.Config_FeatureFlag_specTransform.test_optionsEnumMustBeKnown)                                                                                                               
----------------------------------------------------------------------                                                  
Traceback (most recent call last):                                                                                      
  File "D:\projects\nvda\tests\unit\test_config.py", line 135, in test_optionsEnumMustBeKnown                           
    featureFlag._transformSpec_AddFeatureFlagDefault(                                                                   
  File "D:\projects\nvda\source\config\featureFlag.py", line 182, in _transformSpec_AddFeatureFlagDefault               
    raise VdtParamError(                                                                                                
          ^^^^^^^^^^^^^^                                                                                                
TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg'                                    
                                                                                                                        
======================================================================                                                  
ERROR [0.000s]: test_paramDefaultIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_paramDefaultIsError)                                                                                                                     
----------------------------------------------------------------------                                                  
Traceback (most recent call last):                                                                                      
  File "D:\projects\nvda\tests\unit\test_config.py", line 89, in test_paramDefaultIsError                               
    featureFlag._transformSpec_AddFeatureFlagDefault(                                                                   
  File "D:\projects\nvda\source\config\featureFlag.py", line 160, in _transformSpec_AddFeatureFlagDefault               
    raise VdtParamError(                                                                                                
          ^^^^^^^^^^^^^^                                                                                                
TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg'                                    
                                                                                                                        
======================================================================                                                  
ERROR [0.000s]: test_tooManyParamsIsError (tests.unit.test_config.Config_FeatureFlag_specTransform.test_tooManyParamsIsError)                                                                                                                   
----------------------------------------------------------------------                                                  
Traceback (most recent call last):                                                                                      
  File "D:\projects\nvda\tests\unit\test_config.py", line 126, in test_tooManyParamsIsError                             
    featureFlag._transformSpec_AddFeatureFlagDefault(                                                                   
  File "D:\projects\nvda\source\config\featureFlag.py", line 217, in _transformSpec_AddFeatureFlagDefault               
    raise VdtParamError(                                                                                                
          ^^^^^^^^^^^^^^                                                                                                
TypeError: VdtParamError.__init__() got an unexpected keyword argument 'name_or_msg'                                    
                                                                                                                        
----------------------------------------------------------------------                                                  
Ran 757 tests in 16.563s                                                                                                
                                                                                                                        
FAILED (errors=7)

@SaschaCowley SaschaCowley merged commit d7dc785 into master Nov 8, 2024
@SaschaCowley SaschaCowley deleted the i17328 branch November 8, 2024 03:06
@github-actions github-actions Bot added this to the 2025.1 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2025.1

Development

Successfully merging this pull request may close these issues.

Dependency: update configobj to 5.1.0 commit 8be54629

2 participants

@SaschaCowley @seanbudd