Skip to content

Update robot framework to 7.1.1#17333

Merged
SaschaCowley merged 3 commits into
nvaccess:masterfrom
josephsl:robotframework-7.1.1
Oct 29, 2024
Merged

Update robot framework to 7.1.1#17333
SaschaCowley merged 3 commits into
nvaccess:masterfrom
josephsl:robotframework-7.1.1

Conversation

@josephsl

@josephsl josephsl commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #17329

Summary of the issue:

NVDA is using an outdated version of robot framework (6.1.1).

Description of user facing changes

None

Description of development approach

Updated robot framework to 7.1.1, ensuring that system tests continue to work (pass/fail).

Testing strategy:

Manual and system tests:

  • Manual: updated robot framework to 7.1.1 and ensure that this is picked up from PyPI
  • System tests: make sure system tests do work after updating robot framework (system tests do run).

Known issues with pull request:

Some system tests may fail, but that might not be related to robot framework dependency updates.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@josephsl josephsl requested a review from a team as a code owner October 28, 2024 04:51
@josephsl josephsl requested a review from SaschaCowley October 28, 2024 04:51
@AppVeyorBot

AppVeyorBot commented Oct 28, 2024

Copy link
Copy Markdown
  • PASS: Translation comments check.
  • PASS: License check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • FAIL: System tests (tags: installer NVDA). See test results for more information.
  • Build (for testing PR): https://ci.appveyor.com/api/buildjobs/rd7pp5at4wgawqtj/artifacts/output/l10nUtil.exe nvda_snapshot_pr17333-34429,b7c0353f.exe
  • CI timing (mins):
    INIT 0.0,
    INSTALL_START 1.4,
    INSTALL_END 0.9,
    BUILD_START 0.0,
    BUILD_END 25.0,
    TESTSETUP_START 0.0,
    TESTSETUP_END 0.4,
    TEST_START 0.0,
    TEST_END 18.7,
    FINISH_END 0.2

See test results for failed build of commit b7c0353f98

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Oct 28, 2024
SaschaCowley
SaschaCowley approved these changes Oct 29, 2024
View reviewed changes
Comment thread user_docs/en/changes.md Outdated
@SaschaCowley SaschaCowley merged commit 39c687c into nvaccess:master Oct 29, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Oct 29, 2024
@josephsl josephsl deleted the robotframework-7.1.1 branch November 4, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaschaCowley SaschaCowley SaschaCowley approved these changes

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2025.1

Development

Successfully merging this pull request may close these issues.

Dependency: update robot framework to 7.1.1

4 participants

@josephsl @AppVeyorBot @SaschaCowley @seanbudd