Any suggestions for how to write a unit or system test for this?

It seems like I should be able to provide some HTML, call some function, and then make sure the MathML is returned from this call. I looked at the existing tests and nothing struck me as similar, although I could have easily overlooked a similar test. There is tests/system/robot/chromeTests.py, but I think they all depend on speech and since MathML is not currently packaged with NVDA (hopefully that will change in the next month or so), I can't do a test that relies on speech generation.

If testing this is not currently an option, then this will be ready for review.

• PASS: Translation comments check.
• PASS: License check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/4swpw4lbjogsmiq2/artifacts/output/l10nUtil.exe nvda_snapshot_pr17327-34422,9e2ac7cc.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.3,
  INSTALL_END 0.8,
  BUILD_START 0.0,
  BUILD_END 22.1,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 18.2,
  FINISH_END 0.2

See test results for failed build of commit 9e2ac7ccde

@coderabbitai: as per @XLTechie, any suggestions for a test?

@NSoiffer: I'd be happy to suggest a unit test for this fix.

Since the issue involves elements with role="math" wrapping a <math> element, we can write a unit test to ensure that the MathML is correctly retrieved and processed. Here's an example of how you might write such a test:

import unittest
from some_module import getMathMlFromNode
from some_parser import parseHtmlToNode

class TestMathRoleSpan(unittest.TestCase):
    def test_math_role_span_with_single_math_child(self):
        # HTML content with role="math" wrapping a <math> element
        html_content = '''
            <span role="math">
                <math>
                    <msqrt>
                        <mn>4</mn>
                    </msqrt>
                </math>
            </span>
        '''
        # Parse the HTML content into a node
        node = parseHtmlToNode(html_content)
        # Call the function that retrieves MathML from the node
        mathml = getMathMlFromNode(node)
        # Expected MathML output
        expected_mathml = '''
            <math>
                <msqrt>
                    <mn>4</mn>
                </msqrt>
            </math>
        '''
        # Assert that the retrieved MathML matches the expected output
        self.assertEqual(mathml.strip(), expected_mathml.strip())

if __name__ == '__main__':
    unittest.main()

In this test:

• html_content simulates the HTML snippet where a <span> with role="math" wraps a <math> element.
• parseHtmlToNode is a hypothetical function that parses the HTML string into a node object usable by your processing functions. You might already have a similar function in your test utilities.
• getMathMlFromNode is the function you've modified to handle this case. Replace some_module with the actual module name where this function is defined.
• The test checks that the MathML extracted from the node matches the expected MathML.

If your codebase uses different parsing or testing utilities, you can adjust the above code accordingly. Additionally, if there's an existing test class for MathML processing, you can add this test method to that class.

I hope this helps!

For testing, you will probably have to create a chrome test in the system test framework

However since we don't have mathML support bundled in NVDA yet, I don't think this can be tested

• PASS: Translation comments check.
• PASS: License check.
• PASS: Unit tests.
• FAIL: Lint check. See test results and lint artifacts for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/rfdx0n7r50uysb00/artifacts/output/l10nUtil.exe nvda_snapshot_pr17327-34579,d298d88a.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.5,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  BUILD_END 27.5,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.4,
  TEST_START 0.0,
  TEST_END 18.9,
  FINISH_END 0.2

See test results for failed build of commit d298d88a12