Fix appVolumeAdjuster when state is default#17321
Merged
Merged
Conversation
CyrilleB79
reviewed
Oct 24, 2024
SaschaCowley
requested changes
Oct 28, 2024
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
5 tasks
SaschaCowley
requested changes
Oct 28, 2024
SaschaCowley
left a comment
Member
There was a problem hiding this comment.
@mltony this currently fails because you're getting an instance of AppsVolumeAdjusterFlag, not FeatureFlag, in AudioPanel.onSave. You need to use FeatureFlagCombo ._getControlCurrentFlag, not FeatureFlagCombo._getControlCurrentValue.
https://github.com/mltony/nvda/blob/562eebb936e452011987f410afdd5931d5424d9a/source/gui/settingsDialogs.py#L3216
Contributor
Author
|
@SaschaCowley, fixed and tested. |
SaschaCowley
approved these changes
Nov 3, 2024
SaschaCowley
left a comment
Member
There was a problem hiding this comment.
Thanks for this, @mltony
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17300
Summary of the issue:
When AppVolumeAdjuster state is set to default, pressing OK or Apply button in settings sets the volume of all apps to 100%.
Description of user facing changes
Bug fixed. Now when AppVolumeAdjuster state is set to default, application volumes are not changed.
Description of development approach
Checking for state==default in the right place.
Testing strategy:
Manually tested use case from the issue above.
Known issues with pull request:
N/A
Code Review Checklist:
@coderabbitai summary