Add options to set translation and input braille tables according to NVDA's language by nvdaes · Pull Request #17314 · nvaccess/nvda

nvdaes · 2024-10-21T21:12:21Z

Link to issue number:

Fixes issue #17306

Summary of the issue:

By default, NVDA sets braille tables according to its language. When NVDA's language is changed, by default braille tables are modified accordingly, which may be confusing for users.

Description of user facing changes

In the Braille settings panel, combo boxes for tables have an option to set them according to NVDA's language, so that now this is optional. The automatically selected tables corresponding to the current language are described in parentheses.

Description of development approach

New options have been added to the Braille settings panel. braille, brailleInput and brailleTables modules have been modified so that the "auto" option in configuration can be optional.

Testing strategy:

Tested manually checking that options are presented in the gui and that braille tables are set accordingly.

Known issues with pull request:

None

Code Review Checklist:

Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
API is compatible with existing add-ons.
Security precautions taken.

@coderabbitai summary

… autoBrailleLang

AppVeyorBot · 2024-10-22T16:07:58Z

PASS: Translation comments check.
PASS: License check.
FAIL: Unit tests. See test results for more information.
PASS: Lint check.
PASS: System tests (tags: installer NVDA).
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/ni6nakjd3v9bh12e/artifacts/output/l10nUtil.exe nvda_snapshot_pr17314-34386,0d25bc42.exe
CI timing (mins):
INIT 0.0,
INSTALL_START 1.5,
INSTALL_END 1.0,
BUILD_START 0.0,
BUILD_END 29.7,
TESTSETUP_START 0.0,
TESTSETUP_END 0.4,
TEST_START 0.0,
TEST_END 19.1,
FINISH_END 0.2

See test results for failed build of commit 0d25bc42d7

LeonarddeR

I like this a lot!

Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>

AppVeyorBot · 2024-10-22T19:14:04Z

Build (for testing PR): https://ci.appveyor.com/api/buildjobs/ow9md58l2x2oqwmi/artifacts/output/
CI timing (mins):
INIT 0.0,
INSTALL_START 1.3,
INSTALL_END 1.1,
BUILD_START 0.0,
FINISH_END 15.7

See test results for failed build of commit 4a72f93aeb

nvdaes · 2024-10-22T19:14:39Z

@LeonarddeR , thanks for your review!
I don't understand well the suggestion about tableName. And I get this error.

 if table != self._table.fileName:                                                                                   
   ^^^^^

UnboundLocalError: cannot access local variable 'table' where it is not associated with a value

Perhaps we should revert this suggestion?
Not sure.

nvdaes · 2024-10-23T04:38:02Z

I assumed that @LeonarddeR suggestion was complete, but now I've committed a fix and this should be ready.

nvdaes · 2024-10-23T04:41:34Z

pre-commit.ci run.

Qchristensen

Looks good and will be a welcome improvement for users.

nvdaes · 2024-10-23T08:14:59Z

Thanks Quentin.

LeonarddeR

Just small things, feel free to ignore them if you think your code is more appropriate.

seanbudd

Can you respond to @LeonarddeR's comments? Thanks

Qchristensen

Good pickups on those last couple of comments on the docs changes.

nvdaes · 2024-11-04T05:16:30Z

@LeonarddeR , I tried to use your suggestions in the code, but if I didn't implement them is because they diedn't work as expected.
I trust you a lot and I always try to use your suggestions. I think we can use the current code, unless someone disagrees.

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

nvdaes · 2024-11-04T05:28:43Z

I've accepted the last suggestion and I think that, when checks pass, it will be ready for review again.

LeonarddeR · 2024-11-04T06:18:52Z

It was not at all important, thanks a lot for implementing/fixing this!

nvdaes and others added 2 commits October 21, 2024 23:11

Set auto for output table

41e1f46

Pre-commit auto-fix

0688b68

seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Oct 21, 2024

nvdaes and others added 14 commits October 22, 2024 05:50

Add table name in automatic option

59891d9

Merge branch 'autoBrailleLang' of https://github.com/nvdaes/nvda into…

934692c

… autoBrailleLang

Pre-commit auto-fix

62e92fe

Improvements for input

9f6d84c

Merge branch 'autoBrailleLang' of https://github.com/nvdaes/nvda into…

f189094

… autoBrailleLang

Pre-commit auto-fix

768ba33

Fix braille.py

1fc9737

Fix _set_table in brailleInput

5d00eea

Merge branch 'autoBrailleLang' of https://github.com/nvdaes/nvda into…

66bc9d5

… autoBrailleLang

Merge branch 'master' into autoBrailleLang

96bf3dc

Set config.conf braille translation table to auto when appropriate

db922cb

Fix for translation table

f0d3261

Fix

43e6b4d

Fix auto for output table

3963cd2

Remove code to set table in initialize for auto option

7c24bf6

LeonarddeR suggested changes Oct 22, 2024

View reviewed changes

Comment thread source/braille.py Outdated

Comment thread source/brailleInput.py Outdated

Comment thread source/gui/settingsDialogs.py Outdated

Comment thread source/gui/settingsDialogs.py Outdated

Comment thread source/gui/settingsDialogs.py Outdated

nvdaes added 3 commits October 22, 2024 19:33

Improvements

4a1dc64

Update user guide

d2fb8fe

Update changelog

963d59e

nvdaes changed the title ~~Set auto for output table~~ Add options to set translation and input braille tables according to NVDA's language Oct 22, 2024

Apply suggestions from code review

0d08a08

Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>

Fix for changed variable

30753d2

Fix for settingsDialog

769a73d

nvdaes marked this pull request as ready for review October 23, 2024 07:04

nvdaes requested review from a team as code owners October 23, 2024 07:04

nvdaes requested review from Qchristensen and seanbudd October 23, 2024 07:04

Qchristensen approved these changes Oct 23, 2024

View reviewed changes

LeonarddeR approved these changes Oct 24, 2024

View reviewed changes

Comment thread source/braille.py

Comment thread source/brailleInput.py

seanbudd approved these changes Nov 4, 2024

View reviewed changes

Comment thread user_docs/en/changes.md Outdated

Qchristensen approved these changes Nov 4, 2024

View reviewed changes

nvdaes and others added 2 commits November 4, 2024 06:20

Apply suggestions from code review

1e74b29

Co-authored-by: Sean Budd <seanbudd123@gmail.com>

Fix conflicts

704980b

seanbudd reviewed Nov 4, 2024

View reviewed changes

Comment thread user_docs/en/changes.md

Update user_docs/en/changes.md

aee93b7

seanbudd merged commit f99a457 into nvaccess:master Nov 4, 2024

github-actions Bot added this to the 2025.1 milestone Nov 4, 2024

nvdaes mentioned this pull request Nov 7, 2024

Add an option to preserve configured braille tables when changing NVDA's language #17306

Closed

SaschaCowley linked an issue Nov 7, 2024 that may be closed by this pull request

Add an option to preserve configured braille tables when changing NVDA's language #17306

Closed

Uh oh!

Conversation

nvdaes commented Oct 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Uh oh!

AppVeyorBot commented Oct 22, 2024

Uh oh!

LeonarddeR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AppVeyorBot commented Oct 22, 2024

Uh oh!

nvdaes commented Oct 22, 2024

Uh oh!

nvdaes commented Oct 23, 2024

Uh oh!

nvdaes commented Oct 23, 2024

Uh oh!

Qchristensen left a comment

Choose a reason for hiding this comment

Uh oh!

nvdaes commented Oct 23, 2024

Uh oh!

LeonarddeR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

seanbudd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Qchristensen left a comment

Choose a reason for hiding this comment

Uh oh!

nvdaes commented Nov 4, 2024

Uh oh!

nvdaes commented Nov 4, 2024

Uh oh!

Uh oh!

LeonarddeR commented Nov 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nvdaes commented Oct 21, 2024 •

edited

Loading