Skip to content

Update SCons#17278

Merged
SaschaCowley merged 3 commits into
masterfrom
i17254
Oct 15, 2024
Merged

Update SCons#17278
SaschaCowley merged 3 commits into
masterfrom
i17254

Conversation

@SaschaCowley

Copy link
Copy Markdown
Member

Link to issue number:

Closes #17254

Summary of the issue:

We are currently on SCons version 4.5.2, which was released in March of 2023. The latest version of SCons, version 4.8.1, was released in September 2024.

Description of user facing changes:

None.

Description of development approach

  • Updated the required version of SCons from 4.5.2 to 4.8.1 in requirements.txt.
  • Changed the order of arguments to SCons.Tool.MSCommon.vc.find_vc_pdir to that expected by SCons 4.8.

Testing strategy:

Built the project locally and on Appveyor.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

* Changed order of arguments to  SCons.Tool.MSCommon.vc.find_vc_pdir to that expected by SCons 4.8.
@SaschaCowley SaschaCowley added this to the 2025.1 milestone Oct 11, 2024
@SaschaCowley SaschaCowley added Official builds audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers labels Oct 11, 2024
@SaschaCowley SaschaCowley marked this pull request as ready for review October 11, 2024 05:50
@SaschaCowley SaschaCowley requested a review from a team as a code owner October 11, 2024 05:50
@SaschaCowley SaschaCowley requested a review from seanbudd October 11, 2024 05:50
# Conflicts:
#	user_docs/en/changes.md
@SaschaCowley SaschaCowley merged commit f97bf0b into master Oct 15, 2024
@SaschaCowley SaschaCowley deleted the i17254 branch October 15, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audience/nvda-dev PR or issue is relevant to NVDA / Add-on developers component/build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SCons: update to 4.7 or resolve build traceback if updating to 4.8.1

2 participants