Fixes an issue where using the display speech output braille mode while no braille display is connected causes zero division errors#17243
Merged
Conversation
Member
|
Is this ready for review? This has sat as a draft for 3 weeks |
seanbudd
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #17092
Summary of the issue:
When using the display speech output braille mode with no braille display connected and the braille viewer closed, zero division errors are thrown
Description of user facing changes
The user can have braille mode set to display speech output at all times, without NVDA spamming the log file
Description of development approach
Made the showSpeechInBraille function return without doing anything if the braille.handler object is not enabled
Testing strategy:
I am unable to test it, because when I run NVDA from source it crashes. @josephsl Could you confirm that this works?
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary