Update Add-on Store mirror to use new UX#17228
Merged
Merged
Conversation
Added a new section to the settings section of the user guide describing the update mirror and add-on store mirror dialogs in one. Removed the specific section for the update mirror dialog. Changed the links that pointed to the add-on store dialog to refer to the new unified section. Changed references in source code to refer to the correct user guide sections.
seanbudd
reviewed
Sep 30, 2024
See test results for failed build of commit 739159131a |
Co-authored-by: Sean Budd <sean@nvaccess.org>
seanbudd
approved these changes
Oct 2, 2024
SaschaCowley
commented
Oct 2, 2024
Co-authored-by: Sean Budd <sean@nvaccess.org>
seanbudd
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up to #17099
Summary of the issue:
In PR #17099, the ability to set a mirror to use when accessing the Add-on Store was added.
PR #17151 built upon this, adding the ability to set a mirror for NVDA update checks.
However, it was decided that we needed a more robust way of checking the mirror URLs, and a means of protecting users from accidental changes to the URL.
These UX improvements were implemented for the NVDA update mirror, but not for the Add-on Store server mirror, so as to keep PRs single-issue.
Description of user facing changes
The Add-on Store server mirror settings now use the same UI as the NVDA update check mirror.
Description of development approach
responseValidatoroption to_SetURLDialog, which defaults to always returningTrue.request.Responseobjects to check if they're a valid Add-on Store cache hash (JSON comprising a single string of 7-40 hex digits ).responseValidatorfunction.Testing strategy:
Known issues with pull request:
While not directly related to this issue, note that this work lays part of the groundwork for #17205.
Code Review Checklist:
@coderabbitai summary