Skip to content

soffice: Announce keyboard triggered "double underline" toggling#17187

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
michaelweghorn:michaelweghorn/soffice_announce_double_underline_toggle
Sep 17, 2024
Merged

soffice: Announce keyboard triggered "double underline" toggling#17187
seanbudd merged 1 commit into
nvaccess:masterfrom
michaelweghorn:michaelweghorn/soffice_announce_double_underline_toggle

Conversation

@michaelweghorn

Copy link
Copy Markdown
Contributor

Link to issue number:

Implements one aspect from feature requests in #6915

Summary of the issue:

Commit 46a3436
("soffice: Report keyboard-triggered formatting toggles in Writer (#16413)") implemented announcement of keyboard-triggered formatting changes in LibreOffice Writer, including the one to toggle underline. (When English keyboard layout and UI, the shortcut is Ctrl+B.)

Issue #6915 (among others) requests announcement also for "toggle double underline", which is done via the Ctrl+D keyboard shortcut for an English UI.

Description of user facing changes

When toggling double underline in LibreOffice Writer using the corresponding keyboard shortcut, NVDA announces the new state ("double underline on"/"double underline off"). (#6915, @michaelweghorn)

Description of development approach

Add Ctrl+D to the list gestures handled by the existing gesture handler.

Testing strategy:

  1. start NVDA
  2. start LibreOffice Writer (with English UI and keyboard layout)
  3. Press Ctrl+D to enable double underline
  4. Verify that NVDA announces "double underline on"
  5. Press Ctrl+D to disable double underline again
  6. Verify that NVDA announces "double underline off"
  7. Press Ctrl+U to enable (normal/single) underline
  8. Verify that NVDA announces "underline on"
  9. Press Ctrl+D to enable double underline
  10. Verify that NVDA announces "double underline on"

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

 ### Link to issue number:

Implements one aspect from feature requests in nvaccess#6915

 ### Summary of the issue:

Commit 46a3436
("soffice: Report keyboard-triggered formatting toggles in Writer (nvaccess#16413)")
implemented announcement of keyboard-triggered formatting changes
in LibreOffice Writer, including the one to toggle underline.
(When English keyboard layout and UI, the shortcut is Ctrl+B.)

Issue nvaccess#6915 (among others) requests announcement also for
"toggle double underline", which is done via the Ctrl+D
keyboard shortcut for an English UI.

 ### Description of user facing changes

When toggling double underline in LibreOffice Writer using the corresponding keyboard shortcut, NVDA announces the new state ("double underline on"/"double underline off"). (nvaccess#6915, @michaelweghorn)

 ### Description of development approach

Add Ctrl+D to the list gestures handled by the existing gesture handler.

 ### Testing strategy:

1. start NVDA
2. start LibreOffice Writer (with English UI and keyboard layout)
3. Press Ctrl+D to enable double underline
4. Verify that NVDA announces "double underline on"
5. Press Ctrl+D to disable double underline again
6. Verify that NVDA announces "double underline off"
7. Press Ctrl+U to enable (normal/single) underline
8. Verify that NVDA announces "underline on"
9. Press Ctrl+D to enable double underline
10. Verify that NVDA announces "double underline on"

 ### Known issues with pull request:

None.

 ### Code Review Checklist:

- [x] Documentation:
  - Change log entry
  - User Documentation
  - Developer / Technical Documentation
  - Context sensitive help for GUI changes
- [x] Testing:
  - Unit tests
  - System (end to end) tests
  - Manual testing
- [x] UX of all users considered:
  - Speech
  - Braille
  - Low Vision
  - Different web browsers
  - Localization in other languages / culture than English
- [x] API is compatible with existing add-ons.
- [x] Security precautions taken.

<!-- Please keep the following -->
@coderabbitai summary
@michaelweghorn michaelweghorn marked this pull request as ready for review September 17, 2024 11:44
@michaelweghorn michaelweghorn requested a review from a team as a code owner September 17, 2024 11:44

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanbudd seanbudd merged commit 661da49 into nvaccess:master Sep 17, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Sep 17, 2024
@michaelweghorn michaelweghorn deleted the michaelweghorn/soffice_announce_double_underline_toggle branch September 18, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants