Skip to content

Fix braille breakage when activating say all with a config profile enabled#17164

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:profileFix
Sep 16, 2024
Merged

Fix braille breakage when activating say all with a config profile enabled#17164
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:profileFix

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixed #17163

Summary of the issue:

When you have a config profile attached to say all and activate a config profile, braille is broken until you move out and into the document control.

Description of user facing changes

Braille follows along properly.

Description of development approach

The problem was that in the braille handler, self._tether was set to auto when it was configured to auto. However self._tether should only contain the internal tether state, focus or review. Therefore if it is configured as auto, do not override the internal tether state of the braille handler.

Testing strategy:

Tested str from #17163

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@LeonarddeR LeonarddeR requested a review from a team as a code owner September 12, 2024 09:08
@LeonarddeR LeonarddeR requested a review from seanbudd September 12, 2024 09:08
@seanbudd

Copy link
Copy Markdown
Member

Do you know when this regression was introduced? Should it go to 2024.4 beta?

@LeonarddeR

LeonarddeR commented Sep 16, 2024 via email

Copy link
Copy Markdown
Collaborator Author

@seanbudd seanbudd merged commit 29b6a9b into nvaccess:master Sep 16, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Sep 16, 2024
@LeonarddeR LeonarddeR deleted the profileFix branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Braille output breaks with say all profile assigned

2 participants