@coderabbitai review

Walkthrough

The changes introduce a new sorting functionality in the Add-on Store, allowing users to sort the list of add-ons by various columns such as name, publisher, and status. This feature is implemented through the addition of a control in the storeDialog.py file, which updates dynamically based on user selections. Corresponding documentation updates are made to inform users about the new functionality and its usage.

Changes

Assessment against linked issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

@nvdaes, thanks for tackling this issue. Will be very useful when the date column will be a realty.

As expressed in other occasions, I (and other people) find that there are already enough combo-boxes on top in the Add-on Store's GUI. Moreover, I'd say that adding a combo-box here to sort add-ons whereas the other controls around are for filtering makes the Add-on Store's GUI less clear.

Alternatively, I'd add one more item "Sort by" in the list's context menu with a submenu containing all the names of the column headers. This is similar to Windows Explorer or Desktop context menu (when no item is selected), where you can find a "Sort by" menu item with subitems allowing to sort by name, size, file type, etc.

@CyrilleB79 , thanks for your feedback.
For me, the important thing is that this feature is added, regardless of the control used to implement it.
Anyway, I think that a combo box has the following advantages:

1. It's consistent with other controls used to set the presentation of the list. Other NVDA settings have a lot of combo boxes, checkboxes, etc.
2. I think that context submenus may be more difficult to manage: this combo box has a keystroke and can be reached easily; it's placed after tabs and before any other combo box intentionally, so that we don't focus it unintentionally; we don't need to select or unselect add-ons to use it; if the date is added to the last column, we can just press the combo box shortcut and then the end key, i.e., the first and last option (name and date), probably the more used settings, are easily reachable, and I think that this won't be the case with a submenu.
3. Ihave listened that add-on help is hidden in the store, since previously there was a button to open it. Also, the selected option in the combo box will be visible, whereas, when the context submenu is closed after sorting the list, it would be more difficult to see the column used to the new order. We may not wan't to add more info to the title, and a visual indicator may be shown, but the combo box may be useful to blind users to consult the current column for the order.
4. Feedback is appreciated.

I would also be supportive of adding this to the context menu as well, however my experience is that combo-boxes are a more common UX than context menus for sorting (both in Windows dialogs and the web). I think it makes more sense to keep sorting with the filters, rather than the add-on actions.

• PASS: Translation comments check.
• PASS: License check.
• FAIL: Unit tests. See test results for more information.
• PASS: Lint check.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/0guloieu4d7yj99c/artifacts/output/nvda_snapshot_pr17135-33953,31746862.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.2,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  BUILD_END 17.1,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.4,
  TEST_START 0.0,
  TEST_END 19.2,
  FINISH_END 0.1

See test results for failed build of commit 31746862f4

Finally I've tested this successfully and should be ready for review.

• FAIL: Translation comments check. Translation comments missing or unexpectedly included. See build log for more information.
• PASS: License check.
• PASS: Unit tests.
• PASS: Lint check.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/r16vkm7ddw0k27lb/artifacts/output/nvda_snapshot_pr17135-34011,1040a2a4.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.3,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 15.7,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 18.8,
  FINISH_END 0.1

See test results for failed build of commit 1040a2a4c3

• FAIL: Translation comments check. Translation comments missing or unexpectedly included. See build log for more information.
• PASS: License check.
• PASS: Unit tests.
• PASS: Lint check.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/vinkn2deie6uwq7s/artifacts/output/nvda_snapshot_pr17135-34024,f6339ea6.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.4,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  BUILD_END 16.8,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.4,
  TEST_START 0.0,
  TEST_END 18.9,
  FINISH_END 0.2

See test results for failed build of commit f6339ea667