Walkthrough

The changes introduce enhancements to the add-on store, including a new attribute for tracking submission times of add-ons, a sorting configuration option, and a user interface update for displaying publication dates. Additionally, a settings dialog feature allows users to select the order of add-ons displayed, improving customization and usability.

Changes

Assessment against linked issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

@coderabbitai review

@coderabbitai, I have changed the issue title addressing your comment.

@nvdaes, thank you for updating the issue title! I appreciate your responsiveness.

@coderabbitai, can you suggest how to document manual testing for this?

@nvdaes, to document manual testing for the changes introduced in this PR, you can follow these steps:

1. Verify the New Combo Box in Add-on Store Settings:

• Step 1: Open the NVDA Add-on Store settings panel.
• Step 2: Locate the new combo box for selecting the add-on list order.
• Step 3: Ensure that the combo box is populated with the three sorting options: "Recent add-ons first," "Older add-ons first," and "Alphabetical."
• Step 4: Select each option and save the settings.
• Step 5: Reopen the settings panel to verify that the selected option persists.

2. Test the Sorting Behavior:

• Step 1: With the "Recent add-ons first" option selected, navigate to the add-on store and verify that add-ons are sorted by their publication date, with the most recent add-ons appearing at the top.
• Step 2: Change the sorting option to "Older add-ons first" and verify that the add-ons are now sorted with the oldest add-ons at the top.
• Step 3: Select the "Alphabetical" option and verify that the add-ons are sorted alphabetically by their names.

3. Verify the Display of Publication Dates:

• Step 1: In the add-on store, select an add-on and open its details panel.
• Step 2: Ensure that the publication date is displayed correctly if the submissionTime is available.
• Step 3: Verify that the publication date is formatted correctly and is localized according to the user's language settings.
• Step 4: Check that add-ons without a submissionTime do not display a publication date, and ensure that this does not cause any UI issues.

4. Edge Cases and Error Handling:

• Step 1: Test the behavior when an add-on does not have a submissionTime. Ensure that the add-on is still listed and that the absence of a publication date does not affect the sorting or display.
• Step 2: Verify that the sorting options work correctly even when multiple add-ons lack a submissionTime.
• Step 3: Test the behavior when switching between sorting options rapidly to ensure that the UI updates correctly without any lag or errors.

5. Documenting the Results:

• Step 1: Record the results of each test, noting any discrepancies or issues encountered.
• Step 2: If any issues are found, document the steps to reproduce them and any potential workarounds.
• Step 3: Include screenshots or screen recordings where applicable to provide visual confirmation of the test results.

By following these steps, you can ensure that the new features are thoroughly tested and that the documentation provides a clear record of the manual testing process.

Let me know if you need further assistance or if there are specific areas you'd like to focus on!

@coderabbitai, I'm a blind person and I'd like to know if the size for the publication date column (50) is wider enough.

@nvdaes, it appears that there isn't an explicit width setting for the publication date column in the codebase, or it might be set dynamically. Given this, it's challenging to determine if a width of 50 is sufficient without further context.

To ensure that the publication date is fully visible, I recommend considering a slightly wider column, such as 60 or 70, to accommodate different date formats and potential localization variations. This conservative approach should help avoid any truncation of the date information.

Let me know if you'd like further assistance or if you have any specific preferences!

#!/bin/bash
# Search for the implementation of the publication date column in the codebase.
rg --context 5 'publicationDate' | grep -i 'column\|width'

#!/bin/bash
# Search for the width or size settings related to the publication date column.
rg --context 5 'width\|size' | grep -i 'publicationDate\|column'

@coderabbitai review

@coderabbitai, do you think that this maybe improved in some way?

@coderabbitai, I've fixed the grammar issue. Anything else that I can do?

@nvdaes, thank you for fixing the grammar issue! After reviewing the changes, everything looks good, and I don't see any further issues that need to be addressed. Great job on this PR! 🎉

In contrast, the publication date can be formatted, but sorting items by publication date can produce different results, which may not match timestamp order.
From #16681 (comment)

@nvdaes - you should be able to solve this problem by creating a custom wx.ListCtrl subclass using:

• SortItems to create a custom sort function
• GetSortIndicator to get the current column index for SortItems
• SetItemData to set the date used for sorting
• ShowSortIndicator to make this indicator more obvious

@CyrilleB79 , thanks for your reply. Seems that I have fixed the mentioned issue where the date header wasn't shown, though I don't know if my approach is visually correct.
But at least this will be useful for completing the work and then a visual person may provide more advice.
I'll explain how to sort add-ons by columns in the user guide, as requested by @seanbudd , and my explanation will be based on your comment about this.