Skip to content

Beta to master#17085

Merged
seanbudd merged 3 commits into
masterfrom
beta
Aug 30, 2024
Merged

Beta to master#17085
seanbudd merged 3 commits into
masterfrom
beta

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 30, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Improved cursor behavior in multiline edit controls for Java applications, ensuring accurate auditory feedback for users.
  • Bug Fixes
    • Resolved an issue where NVDA would incorrectly read the last line of text when the cursor was on the second-last line, enhancing user experience and accessibility.

SaschaCowley and others added 3 commits August 30, 2024 12:21
@SaschaCowley
Revert change introduced in c333bef
d2852e6
@SaschaCowley
Added change log entry
d312a7b
@seanbudd
Merge pull request #17084 from nvaccess/try-i17027
4d1a43c 
Revert "Fix reading the last empty line of a text in apps using Java Access Bridge"
@seanbudd seanbudd requested a review from a team as a code owner August 30, 2024 05:11
@seanbudd seanbudd requested a review from SaschaCowley August 30, 2024 05:11
@coderabbitai

coderabbitai Bot commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

The changes include modifications to the _getLineOffsets method in the JAB module, simplifying the logic for calculating line offsets. Additionally, a new feature has been introduced to improve cursor behavior in multiline edit controls within Java applications, ensuring that NVDA accurately reflects the cursor's position when reading text. These updates aim to enhance accessibility and responsiveness in various applications.

Changes

Files Change Summary
source/NVDAObjects/JAB/__init__.py Modified _getLineOffsets method to always call getAccessibleTextLineBounds with offset - 1, simplifying control flow.
user_docs/en/changes.md Introduced a feature to improve cursor behavior in multiline edit controls, ensuring accurate position reporting.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seanbudd seanbudd merged commit 35e3158 into master Aug 30, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2025.1

Development

Successfully merging this pull request may close these issues.

2 participants

@seanbudd @SaschaCowley