Conversation
WalkthroughThe changes introduce a new class, Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
user_docs/en/changes.md (1)
46-46: Ensure clarity and consistency in changelog entries.The changelog entry is clear and references the correct issue number. However, to maintain consistency with the style of one sentence per line, consider rephrasing it slightly for clarity:
* Interact with Data validation dropdown lists in Microsoft Excel 2016 and above. (#15138)
|
With Microsoft® Excel® 2016 (16.0.5448.1000) MSO (16.0.5456.1000) 32 bits, this PR has no effect. Though, I was not experiencing #15138, and the situation is not degraded, fortunately. When I open the list or move the focus in the list with up/downArrows, I get the following error with or without this PR but the values are reported anyway: Just mentioning. But since the values are still reported and the error seems independant of this PR, it's probably not worth caring. |
|
With Microsoft® Excel® 2016 MSO (Version 2407 Build 16.0.17830.20056) 32 bits: On contrary to my tests with Excel® 2016 (16.0.5448.1000), I do not get the errors in the log with Excel 2016 MSO (Version 2407 Build 16.0.17830.20056). |
SaschaCowley
left a comment
There was a problem hiding this comment.
Thanks for this Mick! The fix works for me, and will certainly be very much appreciated when it lands.
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
SaschaCowley
left a comment
There was a problem hiding this comment.
Great, all looks good to me now.
I'm using the same version of Excel as you, with the only difference being that I'm using the x64 build, and I am able to reproduce #15138. All of the comments that give actual build versions on the original issue seem to be using 64 bit Office, so I wonder if this is an x64 issue. Regardless, since performance isn't degraded at all for you, and you don't have the original issue, I don't think there's any harm in merging this. |
|
Yes, given the tests I have made, I have no objection at all to merge this PR. |
Link to issue number:
Fixes #15138
Summary of the issue:
If a cell in Microsoft Excel has a data validation type of list, NvDA does not report anything when it is opened and or when selecting a value.
Note that this is specifically talking about the list shown when the cell has data validation set. The dropdown list shown when auto completing from values in higher cells does report okay.
Technical info
Description of user facing changes
It is now possible tin teract with data validation dropdown lists in Excel. this includes reporting the focused / selected item as you move up and down the list, and reporting focus back on the sheet when the list is closed with enter, space or escape.
Description of development approach
Testing strategy:
In Excel 365:
Further testing from other people on other versions of Excel would be very welcome.
Known issues with pull request:
None known.
Code Review Checklist:
Summary by CodeRabbit