Enhance Microsoft Excel notes command: Press twice to present notes content in browsable message.#16878
Merged
Merged
Conversation
Contributor
WalkthroughThe changes enhance the Microsoft Excel functionality in NVDA by allowing users to press a key combination twice to present notes content in a browsable message. This feature addresses the need to navigate long comments in Excel more effectively. Additionally, NVDA can now report font attributes in speech and braille separately. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NVDA
participant ExcelObject
User->>NVDA: Press NVDA+Alt+C
NVDA->>ExcelObject: Call script_reportComment(gesture)
ExcelObject-->>NVDA: Report comment text
User->>NVDA: Press NVDA+Alt+C (Repeat)
NVDA->>ExcelObject: Call script_reportComment(gesture)
ExcelObject-->>NVDA: Display browsable dialog with comment text
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
SaschaCowley
approved these changes
Jul 18, 2024
… into BrowsableCommentForExcel
Contributor
Author
|
I noticed @SaschaCowley helped me make these suggested changes. Many thanks! |
seanbudd
approved these changes
Jul 18, 2024
Qchristensen
approved these changes
Jul 18, 2024
Qchristensen
left a comment
Member
There was a problem hiding this comment.
Userguide looks good, great work Cary!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixed #14628
Replaces abandoned #15986
Thanks to @tseykovets for most of the work.
Summary of the issue:
Sometimes the text of comment is too long, in order to understand, we may need to navigate by sentence or by word.
Description of user facing changes
This pull request adds the ability to present the text of a comment in browse mode by pressing command twice (NVDA+Alt+C).
Description of development approach
A handler for the number of presses has been added to the script (if repeats).
If pressed twice, presents the information in browse mode (ui.browseableMessage).
Additionally, I added a type hint for the gestures.
Testing strategy:
Manual testing
Known issues with pull request:
Code Review Checklist:
Summary by CodeRabbit
New Features
Documentation