Skip to content

fix up translation comment checks after Ruff format#16814

Merged
seanbudd merged 1 commit intomasterfrom
fixCheckPot
Jul 4, 2024
Merged

fix up translation comment checks after Ruff format#16814
seanbudd merged 1 commit intomasterfrom
fixCheckPot

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented Jul 4, 2024 •
edited by coderabbitai bot
Loading

Link to issue number:

Follow up to #16803

Summary of the issue:

Ruff formatting python code in #16803 caused our translation comments to lose association with translation strings
This causes our scons check to fail.

Description of user facing changes

None

Description of development approach

Move translation comments to reassociated them.

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Summary by CodeRabbit

  • New Features

    • Added an "Exit" button to the NVDA launcher dialog.

  • Enhancements

    • Improved message clarity and detail for various actions in Microsoft Word and Excel.
    • Refined messages related to chart elements in Microsoft Office.
    • Updated descriptions of shapes in the Microsoft Office suite for better clarity.
    • Enhanced message formatting for braille displays and braille input.

  • Bug Fixes

    • Corrected message display in Microsoft Word when changing style and outline level.

  • Documentation

    • Updated and added comments for translator clarity across multiple modules.
    • Improved documentation strings for various functions for better readability.

@seanbudd seanbudd requested a review from a team as a code owner July 4, 2024 04:19
@seanbudd seanbudd requested a review from SaschaCowley July 4, 2024 04:19
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 4, 2024 •
edited
Loading

Walkthrough

This update focuses on refining messages for better clarity and readability across different NVDA components, particularly in Microsoft Word, Excel, and other parts of NVDA's UI. It involves enhanced message formatting, translator comments, and adjusted error handling in different scripts and modules. The change affects how NVDA communicates state changes, such as setting headers in Excel and Word, and provides better context in dialogues and error messages.

Changes

Files/Modules Change Summary
source/NVDAObjects/IAccessible/winword.py, source/NVDAObjects/window/excel.py Updated messages for setting/removing headers in Word and Excel.
source/NVDAObjects/UIA/__init__.py Used ngettext for pluralized messages based on suggestions count.
source/NVDAObjects/__init__.py, source/NVDAObjects/behaviors.py, source/updateCheck.py, source/winAPI/_powerTracking.py Improved and adjusted text and comments for better clarity and context.
source/gui/..., source/addonStore/models/status.py, source/browseMode.py, source/core.py Enhanced descriptive comments, messages, and dialogs across the GUI and core files.
source/NVDAObjects/window/_msOfficeChart.py Enhanced details and message formats for chart-related reporting in Microsoft Office.
source/speech/speech.py, source/config/configFlags.py, source/documentBase.py Adjusted text descriptions and comments related to speech attributes, document formatting, and layouts.
source/brailleDisplayDrivers/freedomScientific.py, source/brailleInput.py, source/globalCommands.py Updated comments and descriptions for braille and global commands.
source/nvda_slave.pyw, tests/checkPot.py Added and adjusted translator comments for user-facing messages.

Possibly related issues

Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7734274 and fb1ee3d.

Files selected for processing (30)
  • source/NVDAObjects/IAccessible/winword.py (2 hunks)
  • source/NVDAObjects/UIA/init.py (1 hunks)
  • source/NVDAObjects/init.py (1 hunks)
  • source/NVDAObjects/behaviors.py (1 hunks)
  • source/NVDAObjects/window/_msOfficeChart.py (7 hunks)
  • source/NVDAObjects/window/excel.py (2 hunks)
  • source/NVDAObjects/window/excelCellBorder.py (1 hunks)
  • source/NVDAObjects/window/winword.py (1 hunks)
  • source/addonStore/models/status.py (1 hunks)
  • source/appModules/foobar2000.py (1 hunks)
  • source/brailleDisplayDrivers/freedomScientific.py (1 hunks)
  • source/brailleInput.py (1 hunks)
  • source/browseMode.py (4 hunks)
  • source/config/configFlags.py (1 hunks)
  • source/core.py (1 hunks)
  • source/documentBase.py (1 hunks)
  • source/globalCommands.py (13 hunks)
  • source/gui/init.py (6 hunks)
  • source/gui/addonStoreGui/controls/messageDialogs.py (1 hunks)
  • source/gui/configProfiles.py (6 hunks)
  • source/gui/installerGui.py (5 hunks)
  • source/gui/logViewer.py (3 hunks)
  • source/gui/settingsDialogs.py (12 hunks)
  • source/gui/startupDialogs.py (1 hunks)
  • source/msoAutoShapeTypes.py (4 hunks)
  • source/nvda_slave.pyw (1 hunks)
  • source/speech/speech.py (9 hunks)
  • source/updateCheck.py (1 hunks)
  • source/winAPI/_powerTracking.py (1 hunks)
  • tests/checkPot.py (1 hunks)
Files not reviewed due to errors (1)
  • source/gui/init.py (no review received)
Files skipped from review due to trivial changes (12)
  • source/NVDAObjects/init.py
  • source/NVDAObjects/window/winword.py
  • source/addonStore/models/status.py
  • source/appModules/foobar2000.py
  • source/brailleDisplayDrivers/freedomScientific.py
  • source/config/configFlags.py
  • source/core.py
  • source/documentBase.py
  • source/gui/addonStoreGui/controls/messageDialogs.py
  • source/nvda_slave.pyw
  • source/winAPI/_powerTracking.py
  • tests/checkPot.py
Additional context used
Path-based instructions (18)
source/gui/logViewer.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/NVDAObjects/window/excelCellBorder.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/gui/startupDialogs.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/gui/configProfiles.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/brailleInput.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/NVDAObjects/IAccessible/winword.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/gui/installerGui.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/updateCheck.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/NVDAObjects/behaviors.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/gui/__init__.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/NVDAObjects/window/_msOfficeChart.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/msoAutoShapeTypes.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/NVDAObjects/window/excel.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/NVDAObjects/UIA/__init__.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/browseMode.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/speech/speech.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/globalCommands.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

source/gui/settingsDialogs.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

Additional comments not posted (57)
source/gui/logViewer.py (1)

57-57: Translation comment correctly added.

The translation comment for the "Exit" menu item is correctly added, ensuring proper association with the translation string.

source/NVDAObjects/window/excelCellBorder.py (1)

162-162: Translation comment correctly added.

The translation comment for border styles in Microsoft Excel is correctly added, ensuring proper association with the translation string.

source/gui/startupDialogs.py (1)

211-211: Translation comment correctly added.

The translation comment for the "Exit" button in the launcher dialog is correctly added, ensuring proper association with the translation string.

source/gui/configProfiles.py (7)

179-181: Translation comments correctly added.

The translation comments for the error message when activating a configuration profile fails are correctly added, ensuring proper association with the translation strings.

214-216: Translation comments correctly added.

The translation comments for the error message when deleting a configuration profile fails are correctly added, ensuring proper association with the translation strings.

332-334: Translation comments correctly added.

The translation comments for the error message when saving configuration profile triggers fails are correctly added, ensuring proper association with the translation strings.

493-494: Translation comments correctly added.

The translation comments for the confirmation prompt when creating a new configuration profile and the selected trigger is already associated are correctly added, ensuring proper association with the translation strings.

525-528: Translation comments correctly added.

The translation comments for the error message when the user attempts to create a configuration profile which already exists are correctly added, ensuring proper association with the translation strings.

537-539: Translation comments correctly added.

The translation comments for the error message when creating a configuration profile fails are correctly added, ensuring proper association with the translation strings.

555-556: Translation comments correctly added.

The translation comments for the prompt asking the user whether they wish to manually activate a configuration profile that has just been created are correctly added, ensuring proper association with the translation strings.

source/brailleInput.py (1)

282-282: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

source/NVDAObjects/IAccessible/winword.py (8)

259-259: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

267-267: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

276-277: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

284-285: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

311-311: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

319-319: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

328-329: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

336-337: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

source/gui/installerGui.py (6)

88-91: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

107-109: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

123-124: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

189-191: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

194-196: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

436-438: Ensure the translator comment is correctly associated with the string.

The translator comment is correctly placed above the string it describes, ensuring that the context is clear for translators.

source/updateCheck.py (1)

652-652: Verify the correctness of the translation comments.

Ensure that the translation comments are correctly associated with the translation strings.

source/NVDAObjects/behaviors.py (1)

646-646: Addition of translator comment.

The translator comment added here will help translators understand the context of the message, which is crucial for accurate translations.

source/NVDAObjects/window/_msOfficeChart.py (7)

436-437: Ensure the translation comment is correctly associated.

The translation comment is correctly associated with the string for reporting the series color.

791-792: Ensure the translation comment is correctly associated.

The translation comment is correctly associated with the string for reporting the slice color in a pie chart.

804-805: Ensure the translation comment is correctly associated.

The translation comment is correctly associated with the string for reporting the series color.

916-917: Ensure the translation comment is correctly associated.

The translation comment is correctly associated with the string for reporting the fraction of a slice in a pie chart.

1074-1075: Ensure the translation comment is correctly associated.

The translation comment is correctly associated with the string for reporting the trendline type, name, and label.

1130-1132: Ensure the translation comment is correctly associated.

The translation comment is correctly associated with the string for reporting details about the chart area.

1161-1165: Ensure the translation comment is correctly associated.

The translation comment is correctly associated with the string for reporting details about the plot area.

source/msoAutoShapeTypes.py (6)

501-504: Ensure consistency in translator comments.

The translator comment has been correctly associated with the translation string, providing useful context for the translators. This is important for maintaining the accuracy of translations.

516-519: Ensure consistency in translator comments.

The translator comment has been correctly associated with the translation string, providing useful context for the translators. This is important for maintaining the accuracy of translations.

531-534: Ensure consistency in translator comments.

The translator comment has been correctly associated with the translation string, providing useful context for the translators. This is important for maintaining the accuracy of translations.

543-546: Ensure consistency in translator comments.

The translator comment has been correctly associated with the translation string, providing useful context for the translators. This is important for maintaining the accuracy of translations.

549-552: Ensure consistency in translator comments.

The translator comment has been correctly associated with the translation string, providing useful context for the translators. This is important for maintaining the accuracy of translations.

555-558: Ensure consistency in translator comments.

The translator comment has been correctly associated with the translation string, providing useful context for the translators. This is important for maintaining the accuracy of translations.

source/NVDAObjects/window/excel.py (6)

1625-1625: Ensure proper association of translation comments.

The translation comment is correctly associated with the translation string.

1631-1631: Ensure proper association of translation comments.

The translation comment is correctly associated with the translation string.

1634-1635: Ensure proper association of translation comments.

The translation comment is correctly associated with the translation string.

1656-1656: Ensure proper association of translation comments.

The translation comment is correctly associated with the translation string.

Line range hint 1662-1662: Ensure proper association of translation comments.

The translation comment is correctly associated with the translation string.

Line range hint 1665-1665: Ensure proper association of translation comments.

The translation comment is correctly associated with the translation string.

source/NVDAObjects/UIA/__init__.py (1)

2726-2727: Correct usage of ngettext for pluralization.

The use of ngettext ensures proper pluralization of the suggestions message based on the count.

source/browseMode.py (3)

461-464: Addition of translation comment for script_toggleSingleLetterNav.

The added docstring provides context for translators, which is helpful for ensuring accurate translations.

2308-2309: Addition of translation comment for script_moveToStartOfContainer.

The added docstring provides context for translators, which is helpful for ensuring accurate translations.

2336-2337: Addition of translation comment for script_movePastEndOfContainer.

The added docstring provides context for translators, which is helpful for ensuring accurate translations.

source/speech/speech.py (7)

2323-2323: Approve translator comment for list item count.

The translator comment for the number of items in a list is clear and correct.

2665-2667: Approve translator comment for text and background colors.

The translator comment for reporting both text and background colors is clear and correct.

2705-2707: Approve translator comment for inserted text.

The translator comment for reporting inserted text is clear and correct.

2716-2718: Approve translator comment for deleted text.

The translator comment for reporting deleted text is clear and correct.

2739-2741: Approve translator comment for marked text.

The translator comment for reporting marked text is clear and correct.

2765-2767: Approve translator comment for strong text.

The translator comment for reporting strong text is clear and correct.

2777-2779: Approve translator comment for emphasized text.

The translator comment for reporting emphasized text is clear and correct.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Outside diff range and nitpick comments (4)
source/gui/settingsDialogs.py (4)

854-855: Ensure consistency in label naming.

The label for the playStartAndExitSoundsCheckBox should be consistent with other labels in terms of capitalization and punctuation.

- label=_("&Play sounds when starting or exiting NVDA"),
+ label=_("P&lay sounds when starting or exiting NVDA"),

924-925: Add translator comments for new labels.

Translator comments help translators understand the context of the strings.

+ # Translators: The label of a checkbox in general settings to toggle automatic checking for updated versions of NVDA.
label=_("Automatically check for &updates to NVDA"),
+ # Translators: The label of a checkbox in general settings to toggle startup notifications for a pending NVDA update.
label=_("Notify for &pending update on startup"),

Also applies to: 936-937

987-989: Improve error message clarity.

The error message should be more user-friendly and provide clear instructions.

- "Unable to copy a file. Perhaps it is currently being used by another process or you have run out of disc space on the drive you are copying to.",
+ "Unable to copy a file. It may be in use by another process or there might not be enough disk space on the destination drive.",

1008-1010: Improve success message clarity.

The success message should be more user-friendly and provide clear confirmation.

- _("Successfully copied NVDA user settings"),
+ _("NVDA user settings copied successfully"),

@seanbudd seanbudd merged commit 4c50375 into master Jul 4, 2024
@seanbudd seanbudd deleted the fixCheckPot branch July 4, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaschaCowley SaschaCowley SaschaCowley approved these changes

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seanbudd @SaschaCowley