Skip to content

QuickNav next menu command: adding more IA2 roles#16670

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
mltony:moreMenu
Jun 17, 2024
Merged

QuickNav next menu command: adding more IA2 roles#16670
seanbudd merged 1 commit into
nvaccess:masterfrom
mltony:moreMenu

Conversation

@mltony

@mltony mltony commented Jun 8, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

N/A

Summary of the issue:

On some websites QuickNav command jump to next menu doesn't work. For example in Jupyter:
https://jupyter.org/try-jupyter/notebooks/?path=notebooks/Intro.ipynb

Description of user facing changes

QuickNav next menu command now works with Jupyter.

Description of development approach

Added one more IA2 role to search for in next menu QuickNav command.

Testing strategy:

Tested on Jupyter website - link above.

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jun 11, 2024
@mltony mltony marked this pull request as ready for review June 15, 2024 22:23
@mltony mltony requested a review from a team as a code owner June 15, 2024 22:23
@mltony mltony requested a review from gerald-hartig June 15, 2024 22:23
@seanbudd

Copy link
Copy Markdown
Member

Thanks @mltony

@seanbudd seanbudd merged commit dd924f0 into nvaccess:master Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants