Use OffsetConverter for OffsetTextInfo find#16657
Merged
Merged
Conversation
See test results for failed build of commit 6e30d0c549 |
seanbudd
approved these changes
Jun 6, 2024
seanbudd
approved these changes
Jun 6, 2024
Member
|
Thanks @LeonarddeR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #16317
Summary of the issue:
Find in browse mode (Virtual Buffers) can be inaccurate when a python character spans two character offsets in the underlying TextInfo, such as when emojis come in to play.
Description of user facing changes
Find functionality is now accurate when a page contains emoji characters and similar.
Description of development approach
Use an OffsetConverter to correct offsets.
Testing strategy:
Tested test case as provided by @CyrilleB79 in #16317 (comment)
Known issues with pull request:
None known
Code Review Checklist: