Skip to content

Making sound split classes and functions private#16606

Merged
seanbudd merged 1 commit into
nvaccess:betafrom
mltony:soundSplitPrivate
May 26, 2024
Merged

Making sound split classes and functions private#16606
seanbudd merged 1 commit into
nvaccess:betafrom
mltony:soundSplitPrivate

Conversation

@mltony

@mltony mltony commented May 24, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

N/A

Summary of the issue:

Following @seanbudd's suggestion in #16591 making classes and functions private.
The rationale is that we would like to refactor sound split code so that more code is going to be reused in application volume adjuster, but #16591 will have to be postponed to v2024.3. So we need to make sound split API private to avoid breaking API changes.

Description of user facing changes

N/A

Description of development approach

Prefixing with underscore.

Testing strategy:

Manual.

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mltony mltony marked this pull request as ready for review May 24, 2024 21:47
@mltony mltony requested a review from a team as a code owner May 24, 2024 21:47
@mltony mltony requested a review from seanbudd May 24, 2024 21:47
@seanbudd seanbudd changed the base branch from master to beta May 26, 2024 23:20

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mltony

@seanbudd seanbudd merged commit 51fe9b7 into nvaccess:beta May 26, 2024
@seanbudd seanbudd added this to the 2024.2 milestone May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants