Skip to content

Fix regression where many blank lines were reported in browse mode#16585

Merged
seanbudd merged 11 commits into
nvaccess:masterfrom
SaschaCowley:fix_figure_aria_hidden_children
May 23, 2024
Merged

Fix regression where many blank lines were reported in browse mode#16585
seanbudd merged 11 commits into
nvaccess:masterfrom
SaschaCowley:fix_figure_aria_hidden_children

Conversation

@SaschaCowley

@SaschaCowley SaschaCowley commented May 22, 2024

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #16554

Summary of the issue:

#16471 introduced a regression whereby many blank lines were reported in browse mode.

Description of user facing changes

Extraneous blank lines are no longer reported in browse mode.

Description of development approach

Updated checks in gecko_ia2.cpp:

  • Check that the length of name is non-zero (SysStringLen returns 0 if the BSTR passed is null)
  • Added check that description's value is not the empty string, as checking that it has a value is necessary but not sufficient.

Testing strategy:

Tested reading the PR for #16471 as described in #16554. Also tested as described in #16471 to ensure changes did not break the new behaviour.

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd changed the title Fix #16471 Fix regression where many blank lines were reported in browse mode May 22, 2024
@seanbudd seanbudd marked this pull request as draft May 22, 2024 03:03
@cary-rowen

cary-rowen commented May 22, 2024

Copy link
Copy Markdown
Contributor

Hi,
Shouldn't regression fixes be for beta versions?

@seanbudd

seanbudd commented May 22, 2024

Copy link
Copy Markdown
Member

@cary-rowen - this regression is on alpha, caused by a PR targeting 2024.3. It's not in the 2024.2 code.

@SaschaCowley - I assume you are still working on this as the diff appears to be empty, so I've marked this a draft

@cary-rowen

cary-rowen commented May 22, 2024

Copy link
Copy Markdown
Contributor

Sorry, I misremembered this

@SaschaCowley SaschaCowley marked this pull request as ready for review May 22, 2024 04:23
@SaschaCowley SaschaCowley requested a review from a team as a code owner May 22, 2024 04:23
@SaschaCowley SaschaCowley requested a review from seanbudd May 22, 2024 04:23
LeonarddeR
LeonarddeR approved these changes May 22, 2024
View reviewed changes

@LeonarddeR LeonarddeR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

seanbudd
seanbudd reviewed May 23, 2024
View reviewed changes
Comment thread nvdaHelper/vbufBackends/gecko_ia2/gecko_ia2.cpp Outdated
@seanbudd seanbudd merged commit ce137cd into nvaccess:master May 23, 2024
@Adriani90

Adriani90 commented May 27, 2024

Copy link
Copy Markdown
Collaborator

It seems there are still blank lines added from time to time to the virtual document when web pages update content dynamically.E.g. on Github insights page while the time stamps for the issues / PRs are updating.

@SaschaCowley

SaschaCowley commented May 29, 2024

Copy link
Copy Markdown
Member Author

Can you open a new issue for this, and if possible provide a concrete repro case?

@Adriani90

Adriani90 commented May 29, 2024

Copy link
Copy Markdown
Collaborator

I can try to report a concrete case and isolate it as far as possible, it seems it happens only in Firefox.

@SaschaCowley SaschaCowley deleted the fix_figure_aria_hidden_children branch August 22, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

+1 more reviewer

@LeonarddeR LeonarddeR LeonarddeR approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Many blank lines in browse mode after #16471 merge

5 participants

@SaschaCowley @cary-rowen @seanbudd @Adriani90 @LeonarddeR