Skip to content

Ensure scons source isn't obfuscated by liblouis test tables target#16537

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
LeonarddeR:sconsFixAlias
May 13, 2024
Merged

Ensure scons source isn't obfuscated by liblouis test tables target#16537
seanbudd merged 1 commit into
nvaccess:masterfrom
LeonarddeR:sconsFixAlias

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #16535
Fixup of #16208

Summary of the issue:

#16208 introduced test tables SCons didn't want to copy to the test directory by default. I tried to fix that by binding testTable to the source target with env.Alias, but that's definitely the wrong way.

Description of user facing changes

Fixed build system.

Description of development approach

Added the test tables as a dependency to the liblouis python wrapper. This ensures that test tables will be there when the python wrapper is build.

Testing strategy:

Removed tests/unit/brailleTables and ensured they were copied properly.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner May 13, 2024 05:47
@LeonarddeR LeonarddeR requested a review from gerald-hartig May 13, 2024 05:47
@LeonarddeR

Copy link
Copy Markdown
Collaborator Author

@hwf1324 could you please have a try?

@seanbudd seanbudd merged commit 49045d2 into nvaccess:master May 13, 2024
@hwf1324

hwf1324 commented May 13, 2024

Copy link
Copy Markdown
Contributor

Everything is normal now.

@LeonarddeR LeonarddeR deleted the sconsFixAlias branch August 23, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: when rebuilding scons source, the source target was obscured and could not be run from source.

3 participants