Ensure scons source isn't obfuscated by liblouis test tables target#16537
Merged
Conversation
Collaborator
Author
|
@hwf1324 could you please have a try? |
seanbudd
approved these changes
May 13, 2024
Contributor
|
Everything is normal now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #16535
Fixup of #16208
Summary of the issue:
#16208 introduced test tables SCons didn't want to copy to the test directory by default. I tried to fix that by binding testTable to the source target with env.Alias, but that's definitely the wrong way.
Description of user facing changes
Fixed build system.
Description of development approach
Added the test tables as a dependency to the liblouis python wrapper. This ensures that test tables will be there when the python wrapper is build.
Testing strategy:
Removed
tests/unit/brailleTablesand ensured they were copied properly.Known issues with pull request:
None known
Code Review Checklist: