Normalize references to Insert keys#16489
Conversation
|
Hi, |
See test results for failed build of commit a230d1e813 |
|
Thanks for the quick feedback, @zstanecic. :) The few commenters on #13648 seemed all to agree that the naming conventions should be made the same in both areas. So, to clarify, should I have called it something other than simply "Insert", or is the change not needed overall? I know it's a pretty old issue, so maybe thoughts on it have changed since then. Thank you again. :) |
|
In my opinion, change is not needed overall, because we have two insert keys, which are differently named in the windows terminology. This change may confuse users. |
|
@zstanecic main insert and extended insert refer to the same key in NVDA's documentation and GUI. On a normal keyboard, it's located on the 6-key pad above the 4 arrow keys. On the other side, you have the numpad insert key, which is the 0 key of the numpad when numlock is off. Thus, you have the numpad insert key and the other one. The current PR'aims to use a unique term (or expression) for this other insert key. |
|
Sorry about that. I should've double-checked the status of the freeze before posting. Updated my branch and redid my changes. Should be good now. If not, I'm happy to fix anything I broke. :) |
See test results for failed build of commit 3502b71ef5 |
Qchristensen
left a comment
There was a problem hiding this comment.
Looks good. I have never found a reference to "Extended insert". The Microsoft Style Guide only references the "Insert key" (although doesn't distinguish between the two): https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/keys-keyboard-shortcuts
|
Could you please update the system tests so that they pass? The strings in the welcome dialog need updating |
The Welcome Screen and User Guide used different terms, "main Insert" and "Extended Insert", to refer to the same key. Call it simply the "Insert" key in both places so that terminology is consistent. Also update system startup tests to reflect the new Welcome Screen text.
|
@seanbudd I seem to be having the same problem with running system tests as was raised in #13894, where crash dumps are not being generated during the crash tests, causing those three to fail. I've spent quite a while looking through the test libraries, my temp directories, running tests individually, running on a fresh repo, etc., and can't figure what's going on. The "read welcome dialog" test is passing now, though, and only the "restart on * crash" tests fail, so I decided to push changes and see what AppVeyor says, based on your feedback in that issue linked above. Hope that's acceptible. And this is why I started with a very small issue... |
Link to issue number:
Fixes #13648
Summary of the issue:
The Welcome Screen and User Guide used different terms, "main Insert" and "Extended Insert" respectively, to refer to the same key.
Description of user facing changes
Both the Welcome Screen and User Guide now call Extended/main Insert by simply "Insert."
Description of development approach
Modified wording in userGuide and startupDialogs files, as well as the startup system test that checks the Welcome Screen text.
Testing strategy:
Rebuilt NVDA with
scons source user_docsandscons distand checked both places where changes are made. Ran all system tests.Known issues with pull request:
Code Review Checklist:
Notes
Translations were not attempted, as I don't speak any other languages, and it looks to me like there are other people and processes to handle that. I am new to NVDA, though, so if I need to do anything to make that happen, or if I forgot anything or made any errors in the code or starting the PR, please let me know. Thank you in advance.