Add pfx files to .gitignore#16472
Merged
Merged
Conversation
seanbudd
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The current development documentation on creating self-signed builds of NVDA instructs users to save their PFX file to their NVDA repository root. As this directory is under version control, Git will then recognise the PFX file as a candidate for versioning. However, signing certificates should not be committed to VC.
Description of user facing changes
Git will now ignore PFX files in this repository. There are no end-user facing changes.
Description of development approach
Added
*.pfxto.gitignore.Testing strategy:
Ran
git statusto ensure that Git no-longer shows PFX certificates as untracked files.Known issues with pull request:
None
Code Review Checklist:
N/A