Skip to content

Only report captions when entering and exiting them#16445

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
SaschaCowley:report_caption_once
May 8, 2024
Merged

Only report captions when entering and exiting them#16445
seanbudd merged 4 commits into
nvaccess:masterfrom
SaschaCowley:report_caption_once

Conversation

@SaschaCowley

@SaschaCowley SaschaCowley commented Apr 24, 2024

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #14874

Summary of the issue:

NVDA reports the word "caption" before every element in a figcaption element, or before each line in same when navigating by line in browse mode.

Description of user facing changes

NVDA now reports "caption" only when first entering a figure caption, and "out of caption" when leaving it.

Description of development approach

Changed textInfos.ControlField.getPresentationCategory to return PRESCAT_CONTAINER when its role is controlTypes.Role.CAPTION .

Testing strategy:

Manually tested in Firefox with my figure example webpage

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@Adriani90 Adriani90 mentioned this pull request Apr 24, 2024
Open
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 30, 2024
@seanbudd

seanbudd commented May 1, 2024

Copy link
Copy Markdown
Member

is this ready for review?

@SaschaCowley SaschaCowley marked this pull request as ready for review May 1, 2024 07:20
@SaschaCowley SaschaCowley requested a review from a team as a code owner May 1, 2024 07:20
@SaschaCowley SaschaCowley requested a review from gerald-hartig May 1, 2024 07:20
@SaschaCowley

SaschaCowley commented May 1, 2024

Copy link
Copy Markdown
Member Author

is this ready for review?

Apologies, I was waiting for checks to complete last week, and completely forgot to mark it as ready!

seanbudd
seanbudd reviewed May 1, 2024
View reviewed changes
Comment thread user_docs/en/changes.t2t Outdated
@seanbudd seanbudd added this to the 2024.3 milestone May 7, 2024
@seanbudd

seanbudd commented May 7, 2024

Copy link
Copy Markdown
Member

Could you move the changes to the new changes.md for this PR please?

@seanbudd seanbudd added the blocked/merge-conflicts Merge conflicts exist on this PR label May 7, 2024
@SaschaCowley
Merge branch 'master' into test
26bbfec 
Moved changes from T2T to markdown
@seanbudd seanbudd merged commit 6e99a50 into nvaccess:master May 8, 2024
@SaschaCowley SaschaCowley deleted the report_caption_once branch August 22, 2024 05:02
@Adriani90 Adriani90 mentioned this pull request Jun 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

+1 more reviewer

@gerald-hartig gerald-hartig gerald-hartig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocked/merge-conflicts Merge conflicts exist on this PR conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. queued for merge

Projects

None yet

Milestone

2024.3

Development

Successfully merging this pull request may close these issues.

NVDA announces 'caption' before every element within figcaption element

3 participants

@SaschaCowley @seanbudd @gerald-hartig