Fix exception when triggering style navigation commands in an empty document#16430
Merged
Conversation
seanbudd
approved these changes
Apr 21, 2024
Member
|
The issue reference seems wrong here - is this meant to fix #16405 |
Contributor
Author
|
No issue reference is correct in the original description. In that issue there's a PDF document made of screenshots, so it indeed appears as an empty document in NVDA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16407
Summary of the issue:
Exception during style navigation command in an empty document
Description of user facing changes
N/A
Description of development approach
Detecting this case and returning early.
Testing strategy:
Tested on use case from the issue.
Known issues with pull request:
N/A
Code Review Checklist: