Fix Eclipse and Dbeaver Autocomplete on Windows 11#16417
Merged
Conversation
See test results for failed build of commit 97e8ccafdb |
Contributor
Author
|
Performed some tests using the latest build on the Windows 10 machine and it continues working as well. |
seanbudd
reviewed
Apr 18, 2024
| - | ||
|
|
||
| == Bug Fixes == | ||
| - NVDA will announce correctly the autocomplete suggestions in Eclipse and other Eclipse-based environments on Windows 11. (#16416, @thgcode) |
Member
There was a problem hiding this comment.
this will need to be moved to 2024.3 when the change log section is created
seanbudd
reviewed
Apr 18, 2024
seanbudd
approved these changes
Apr 21, 2024
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
a6ca3e4 to
56c7c52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
closes #16416
Summary of the issue:
On Windows 11, some controls are above the Dbeaver autocomplete suggestions dialog, causing the check to see if is an autocomplete list item to fail.
Description of user facing changes
NVDA will speak the Dbeaver autocomplete list items on Windows 11 again.
Description of development approach
The solution was to improve this check to use the simple object navigation mode to ignore unwanted objects from the check and add the check for the start menu that is a Toggle Button on Windows 11.
Testing strategy:
Opened Dbveaver.
Pressed CTRL+ALT+ENTER on the sample database to open the console.
Typed selec. NVDA spoke the suggestions.
Known issues with pull request:
None at present.
Code Review Checklist: