Skip to content

Vertical quickNav fix#16388

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
mltony:verticalFix2
Apr 15, 2024
Merged

Vertical quickNav fix#16388
seanbudd merged 3 commits into
nvaccess:masterfrom
mltony:verticalFix2

Conversation

@mltony

@mltony mltony commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #16387
Closes #16386

Summary of the issue:

Exception when trying to use vertical quickNav in excel browse mode.
Exception when trying to use vertical quickNav on an empty word document.

Description of user facing changes

Fixed exception. Now message "not available" is spoken in excel. In empty word document "no next paratgraph" message is spoken.

Description of development approach

Moved _iterSimilarParagraph() method from BrowseModeTreeInterceptor to BrowseModeDocumentTreeInterceptor class.
Catching RuntimeError coming from MSWord textInfo when calling .collapse().

Testing strategy:

Tested manually on specified test cases.

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mltony mltony marked this pull request as ready for review April 12, 2024 18:25
@mltony mltony requested a review from a team as a code owner April 12, 2024 18:25
@mltony mltony requested a review from SaschaCowley April 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants