Fast vertical QuickNav in Gecko-based textInfos#16385
Merged
Merged
Conversation
Collaborator
|
Regarding the "time out on large documents by design" you spoke of in the issue:
Can you make that timeout configurable?
I do not suggest a UI element for it, but just a hidden config value so that it
can be adjusted by anyone wishing to experiment.
|
Contributor
Author
|
I don't have any timeout logic in vertical navigation. What I mean by timeout is that some other part of NVDA - I suspect watchdog - prevents scripts from running for too long and interrupts them after 10 seconds. I am not familiar with that logic so don't know whether it's configurable. |
Collaborator
|
How is this suposed to work in Chromium browsers when you use UiA? If this is not gonna work there, we should note that in the user guide or throw a message when people try to navigate vertically while using UIA. |
Contributor
Author
|
It still works in edge+UIA - I just tested. Just not as fast. |
seanbudd
reviewed
Apr 15, 2024
seanbudd
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16382.
Summary of the issue:
Vertical navigation is too slow.
Description of user facing changes
N/A
Description of development approach
Retrieving x coordinate faster in Gecko textInfo by doing a direct IAccessible2 call - as opposed to creating an NVDAObject. According to my rough measurement, this speeds up vertical navigation about 10 times.
Testing strategy:
Tested on usecase provided in the issue above.
Known issues with pull request:
N/A
Code Review Checklist: