Skip to content

Make add-on reviews available from all tabs of the store#16368

Merged
michaelDCurran merged 4 commits into
nvaccess:masterfrom
nvdaes:rev
Apr 7, 2024
Merged

Make add-on reviews available from all tabs of the store#16368
michaelDCurran merged 4 commits into
nvaccess:masterfrom
nvdaes:rev

Conversation

@nvdaes

@nvdaes nvdaes commented Apr 6, 2024

Copy link
Copy Markdown
Collaborator
  • Show review URL for installed add-ons
  • Update changelog
  • Update user guide

Link to issue number:

Fixes #16179

Summary of the issue:

The community reviews action, and the reviews URL, is not available in installed and incompatible add-ons tab of the store.

Description of user facing changes

The community reviews action, and the reviews URL, will be available in all tabs of the store.

Description of development approach

Fix reviewUrl variable assignment in the _createInstalledStoreModelFromData function of addonStore/models/addon.py

Testing strategy:

  • Checked that the community reviews action is available from the installed and incompatible tabs for add-ons installed from the store, and the reviews webpage is shown in the details panel.
  • Checked that, when an add-on like clipContentsDesigner is installed from an external source, the reviews URL action and webpage aren't presented.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@nvdaes nvdaes changed the title rev Make add-on reviews available from all tabs of the store Apr 6, 2024
@nvdaes nvdaes marked this pull request as ready for review April 6, 2024 04:36
@nvdaes nvdaes requested review from a team as code owners April 6, 2024 04:36
XLTechie
XLTechie approved these changes Apr 6, 2024
View reviewed changes

@XLTechie XLTechie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of change suggestions to that section of the user guide. Otherwise LGTM!

Comment thread user_docs/en/userGuide.t2t Outdated
Comment thread user_docs/en/userGuide.t2t Outdated
@nvdaes @XLTechie
Apply suggestions from code review
97120f7 
Co-authored-by: Luke Davis <8139760+XLTechie@users.noreply.github.com>
@nvdaes

nvdaes commented Apr 6, 2024

Copy link
Copy Markdown
Collaborator Author

@XLTechie , thanks for your review. I've applied your suggested changes.

@michaelDCurran michaelDCurran merged commit 103244e into nvaccess:master Apr 7, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

@Qchristensen Qchristensen Awaiting requested review from Qchristensen Qchristensen was automatically assigned from nvaccess/userdocs

+1 more reviewer

@XLTechie XLTechie XLTechie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.2

Development

Successfully merging this pull request may close these issues.

Add-on Store: "Community reviews" action should be available in Installed add-ons tab too

4 participants

@nvdaes @XLTechie @michaelDCurran @nvaccessAuto