Skip to content

Add spanish for Greek text braille table, added in Liblouis 3.29#16355

Merged
michaelDCurran merged 2 commits into
nvaccess:masterfrom
ivnc:liblouis-grc_es
Apr 8, 2024
Merged

Add spanish for Greek text braille table, added in Liblouis 3.29#16355
michaelDCurran merged 2 commits into
nvaccess:masterfrom
ivnc:liblouis-grc_es

Conversation

@ivnc

@ivnc ivnc commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

The Liblouis braille transcriber was updated in #16259, but the newly added grc-international-es.utb table, as noted in the release notes at https://github.com/liblouis/liblouis/releases/tag/v3.29.0 (New features section), was not added to the NVDA's table list.

Description of user facing changes

New table in the table list called "Spanish for Greek text".
Changelog entry added in #16259 has been also extended to reflect this update.

Description of development approach

Call addTable() as for all other tables.

Testing strategy:

UI test.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@ivnc ivnc requested a review from a team as a code owner April 2, 2024 15:58
@ivnc ivnc requested a review from gerald-hartig April 2, 2024 15:58
@ivnc ivnc changed the title Add Greek for Spanish text braille table, added in Liblouis 3.29 Add spanish for Greek text braille table, added in Liblouis 3.29 Apr 2, 2024
@michaelDCurran michaelDCurran merged commit a9f4024 into nvaccess:master Apr 8, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants