Remove profile from dirty list when deleting it#16344
Merged
Merged
Conversation
michaelDCurran
approved these changes
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16343
Summary of the issue:
When a dirty (modified) profile is deleted and the config is then saved, an error is raised in the function that saves the configuration. This may lead to other dirty profiles not being saved.
Description of user facing changes
A rare case where profiles are not saved is fixed.
Description of development approach
Remove the profile from dirty profiles list when it is deleted.
Testing strategy:
Manual testing STR from #16343.
Known issues with pull request:
None
Code Review Checklist: