Skip to content

Add sound split disabled mode#16331

Merged
michaelDCurran merged 4 commits into
nvaccess:masterfrom
mltony:soundSplitOff
Apr 8, 2024
Merged

Add sound split disabled mode#16331
michaelDCurran merged 4 commits into
nvaccess:masterfrom
mltony:soundSplitOff

Conversation

@mltony

@mltony mltony commented Mar 23, 2024

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #16287

Summary of the issue:

Adding disabled sound split mode

Description of user facing changes

Adding disabled sound split mode

Description of development approach

  1. If sound split mode is disabled at startup, we're not touching any volumes.
  2. If user toggles to disabled mode, then first we set mode to NVDA_BOTH_APPS_BOTH to effectively restore the volumes, then set sound pslit state to off.

Testing strategy:

Manual

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@mltony mltony marked this pull request as ready for review March 23, 2024 21:33
@mltony mltony requested a review from a team as a code owner March 23, 2024 21:33
@mltony mltony requested a review from michaelDCurran March 23, 2024 21:33
@AppVeyorBot

AppVeyorBot commented Mar 23, 2024

Copy link
Copy Markdown

See test results for failed build of commit 6c81d76403

@cary-rowen

cary-rowen commented Mar 24, 2024

Copy link
Copy Markdown
Contributor

Hi @mltony

Thank you for your work.

I tested this snapshot,
I first selected "NVDA on the left and applications on the right" in the "Audio" settings panel, clicked OK, and NVDA performed the expected.

Then, I slected "Sound split disabled" in combo box in the "audio" settings panel and click "OK" did not disable sound splitt.

However, when I use the gesture nvda+alt+S it can be disabled successfully.

Thanks

@mltony

mltony commented Mar 24, 2024

Copy link
Copy Markdown
Contributor Author

@cary-rowen, just fixed that, please try again.

LeonarddeR
LeonarddeR reviewed Mar 25, 2024
View reviewed changes

@LeonarddeR LeonarddeR left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this

Comment thread source/audio/soundSplit.py Outdated
@LeonarddeR

LeonarddeR commented Mar 25, 2024

Copy link
Copy Markdown
Collaborator

Personally, I think the difference between off and NVDA in both channels and applications in both channels is a bit vague at first sight. The documentation definitely needs updating, but may be debate about the UX first? @Qchristensen What do you think?

@michaelDCurran michaelDCurran merged commit 25f562f into nvaccess:master Apr 8, 2024
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

+1 more reviewer

@LeonarddeR LeonarddeR LeonarddeR left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.2

6 participants

@mltony @AppVeyorBot @cary-rowen @LeonarddeR @michaelDCurran @nvaccessAuto