Windows 11/modern keyboard: handle hardware keyboard input suggestions announcements again#16313
Merged
Merged
Conversation
Contributor
Author
|
Hi, Note: this PR makes first part of UIA element selected event handler in emoji panel app module redundant - effectively the IME candidate window Automation Id check becomes dead code, and I'll remove it in the next commit (please hold on). Also, in IME candidate item class, moving Windows 11 and focus check to the end of the element selected event handler method will allow NVDA to announce visible IME candidates when changing IME pages, but I'm deferring it for a while to test it a bit more. Thanks. |
…l when handling show event from IME candidate UI if Automation Id is 'IME_Prediction'Window'. Re nvaccess#16283. When show event is handled in candidate UI, descend one more level if UIA Automation Id is 'IME_PredictionWindow' a.k.a. hardware keyboard input suggestions. This allows hardware keyboard input suggestions item in Windows 11 to handle element selected event (with some refinements).
…t focused on candidate UI. Re nvaccess#16283. Windows 11 hardware keyboard input suggestions: announce top suggestion if keyboard input suggestion is enabled just as it does in Windows 10. This is done by refining UIA element selected event in IME candidate item class - instead of vetoing it in Windows 11, it will be vetoed if gain focus event is pending/parent element is candidates list.
…ion announcement. Re nvaccess#16283
… Id check as it is now dead code. Re nvaccess#16283. Now that IME candidate UI knows where candidate items are in Windows 11, there is no need to do redundant checks in app module version of element selected event handler, making it dead code (and thus removed).
michaelDCurran
approved these changes
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16283
Summary of the issue:
In Windows 11, NVDA does not announce top suggestion from hardware keyboard input suggestions list.
Description of user facing changes
NVDA will once again announce hardware keyboard input suggestions.
Description of development approach
Edited IMECandidateUI/IMECandidateItem classes in emoji panel app module:
Testing strategy:
Manual testing:
Known issues with pull request:
NVDA may announce CJK IME elements when IME window is opened the first time after starting NVDA, and NVDA does not announce CJK IME candidates in subseqent window open event from IME window. This is due to a focus entered event coming from IME candidate UI element, which should be addressed in a different issue/PR combination (UIA Automation Id's are different).
Code Review Checklist: