Skip to content

Merge beta to master#15931

Merged
seanbudd merged 2 commits into
masterfrom
beta
Dec 18, 2023
Merged

Merge beta to master#15931
seanbudd merged 2 commits into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

No description provided.

burmancomp and others added 2 commits December 18, 2023 09:47
fixes #15671

Summary of the issue:
Albatross driver handled Esp32 microcontroller as Albatross display if controller send valid init packet. This is problem especially when displays are detected automatically.

Description of user facing changes
When using usb connection, driver can check that bus reported device description is "Albatross Braille Display". Esp32 is not detected automatically as Albatross.

Description of development approach
_searchPorts function blocks port if VID and PID are correct but bus reported bus reported device description is not "Albatross Braille Display", in other cases port is valid to try to connect.
Translations exported from Crowdin as a zip file and then unpacked into NVDA repository.
Note that all po files have changed due to:

Any custom copyright / other comments in the header has been stripped.
Crowdin metadata comments have been added
location comments added for every string (our old translation system used to strip these)
Subsequent merges should not be anywhere near as large. Size mostly due to the re-adding of the location comments for each string.
@seanbudd seanbudd requested a review from a team as a code owner December 18, 2023 00:43
@seanbudd seanbudd merged commit 0632ee8 into master Dec 18, 2023
@seanbudd seanbudd added this to the 2024.2 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants