Fix hovering on cell in braille viewer#15899
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15895
Summary of the issue:
Activation of routing cursor in the braille viewer by hovering the mouse on the cell does not work anymore in last alpha. This is due to wxPython upgrade, since
inttypes is now expected for some functions whenfloatwas tolerated before. More specifically,wx.Colournow expects 3 integers.Description of user facing changes
Mouse hovering to activate the routing cursor of a cell in the braille viewer works again.
Description of development approach
Convert the 3 numeric values passed to
wx.Colourto integers.Testing strategy:
Tested that hovering a cell with the mouse activates the routing cursor.
Known issues with pull request:
None
Change log
Not needed, unreleased regression appeared with wxPython upgrade.
Code Review Checklist: