Skip to content

Fix hovering on cell in braille viewer#15899

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:fixBrlVwr
Dec 10, 2023
Merged

Fix hovering on cell in braille viewer#15899
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:fixBrlVwr

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #15895

Summary of the issue:

Activation of routing cursor in the braille viewer by hovering the mouse on the cell does not work anymore in last alpha. This is due to wxPython upgrade, since int types is now expected for some functions when float was tolerated before. More specifically, wx.Colour now expects 3 integers.

Description of user facing changes

Mouse hovering to activate the routing cursor of a cell in the braille viewer works again.

Description of development approach

Convert the 3 numeric values passed to wx.Colour to integers.

Testing strategy:

Tested that hovering a cell with the mouse activates the routing cursor.

Known issues with pull request:

None

Change log

Not needed, unreleased regression appeared with wxPython upgrade.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review December 10, 2023 23:06
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner December 10, 2023 23:06
@CyrilleB79 CyrilleB79 requested a review from seanbudd December 10, 2023 23:06

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit e9ef17f into nvaccess:master Dec 10, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Braille Viewer: 'Hover for Cell Routing' option not functioning correctly, produces error sound

3 participants