Skip to content

Added link to Liblouis in Braille support section and contributing guidelines to help section#15896

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
Adriani90:master
Dec 10, 2023
Merged

Added link to Liblouis in Braille support section and contributing guidelines to help section#15896
seanbudd merged 4 commits into
nvaccess:masterfrom
Adriani90:master

Conversation

@Adriani90

@Adriani90 Adriani90 commented Dec 9, 2023

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

n/a

Description of user facing changes

Added Link to Liblouis to be consistent for what has been done in the synth support section
Added link to contributing guidelines to not only encourage to submit issues and requests, but also to encurage active contribution through other activities as well.

Description of development approach

n/a

Testing strategy:

Tested that the links show up correctly in the user guide.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@Adriani90 Adriani90 requested a review from a team as a code owner December 9, 2023 23:15
@Adriani90 Adriani90 changed the title Added link to Liblouis in Braille support section and contributing guidelines to community section Added link to Liblouis in Braille support section and contributing guidelines to help section Dec 10, 2023
seanbudd
seanbudd reviewed Dec 10, 2023
View reviewed changes
Comment thread user_docs/en/userGuide.t2t Outdated
Comment thread user_docs/en/userGuide.t2t Outdated
Adriani90 and others added 2 commits December 11, 2023 00:07
@Adriani90 @seanbudd
Update user_docs/en/userGuide.t2t
4b11a24 
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
@Adriani90 @seanbudd
Update user_docs/en/userGuide.t2t
7eac57c 
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
seanbudd
seanbudd reviewed Dec 10, 2023
View reviewed changes
Comment thread user_docs/en/userGuide.t2t Outdated
Qchristensen
Qchristensen requested changes Dec 10, 2023
View reviewed changes
Comment thread user_docs/en/userGuide.t2t Outdated
seanbudd
seanbudd approved these changes Dec 10, 2023
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Adriani90 !

@seanbudd seanbudd merged commit 5eada84 into nvaccess:master Dec 10, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qchristensen Qchristensen Qchristensen requested changes

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2024.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Adriani90 @seanbudd @Qchristensen @nvaccessAuto