Skip to content

Improve documentation about reviewing add-ons from the store#15887

Merged
seanbudd merged 3 commits into
nvaccess:masterfrom
nvdaes:improveReviewAddonsDocumentation
Dec 6, 2023
Merged

Improve documentation about reviewing add-ons from the store#15887
seanbudd merged 3 commits into
nvaccess:masterfrom
nvdaes:improveReviewAddonsDocumentation

Conversation

@nvdaes

@nvdaes nvdaes commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

Link to issue number:

Part of issue #15576.

Summary of the issue:

Now, add-ons can be reviewed from GitHub discussions, linked in the Available add-ons tab of the store.

Description of user facing changes

This improves documentation for this feature:

  • Explained that this action can be found in the Available add-ons tab.
  • Remove reference to comment on addon versions, since comments aren't longer added to add-ons metadata.

Description of development approach

n/a

Testing strategy:

n/a

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@nvdaes

nvdaes commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator Author

@Adriani90 and @CyrilleB79 , I haven't opened a new issue for this. Hope this is valid, or let me know if I should do it.
Also cc: @XLTechie

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 51d674e670

@CyrilleB79

Copy link
Copy Markdown
Contributor

I have not checked if the documentation matches the behaviour of this feature since I have not followed closely this feature.

Anyway, there is no need to open an issue for a small documentation change; this PR is enough.

Note that you have liblouis submodule modified erroneously in this PR. Please fix it.

@nvdaes

nvdaes commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator Author

Note that you have liblouis submodule modified erroneously in this PR. Please fix it.

Thanks Cyrille. Hope this is fixed now.

@nvdaes nvdaes marked this pull request as ready for review December 6, 2023 21:15
@nvdaes nvdaes requested a review from a team as a code owner December 6, 2023 21:15
@nvdaes nvdaes requested a review from Qchristensen December 6, 2023 21:15
@seanbudd seanbudd merged commit e72d578 into nvaccess:master Dec 6, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants